how we write/review code in big tech companies
Vložit
- čas přidán 9. 02. 2020
- HOW DO I GET A TECH JOB?
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
📚 Video courses from JomaClass:
🎓 New to programming? Learn Python here: bit.ly/joma_python
🎓 Learn SQL for data science and data analytics: bit.ly/joma_sql
🎓 Data Structures and Algorithms: bit.ly/joma_dsa
💼 Resume Template and Cover letter I used for applying to software internships and full-time jobs:
resume.joma.io
💼 Interviewing for jobs now? Get access to interview question database, courses, coaching, and peer community today:
www.tryexponent.com/?ref=joma
📱 SOCIAL MEDIA
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
/ jomakaze
/ jomakaze
/ jomakaze
Some of the links in this description are affiliate links that I get a kickback from
LGTM = Looks good to me
Lesbian, Gay, Transgender and Multisexual
nvm i Googled it
Do you want to be an ex-FAANG engineer? test_porndora passed that well? 8-)
@@anaswip me too 😄
I thought
Looking goods thanks mate 😂
As someone once said, "Being well-educated just means you are confused on a higher level" 😂😂
lmao
😭😭😭😭this just spoke to me on a spiritual level 😭😭😭😭
I'm in fucking tears mate!HA!
yo where does this quote comes from? Can't find it on google
this is noted down, new fav quote haha
Step 1: Stack Over Flow
Step 2: See that you’re the first one to ask
Step 3: *PANIC*
Step 4: Realize you added the wrong tags.
step *: you finally get an answer which the original asker approved but it still doesn't fix you problem.
Step 4: You worded it wrong
@@RonWonWon not even close
can you tell me that how much time does it take to answer the ques that you've asked?
I love how this feeling never goes away no matter how much you learn. It kinda binds all of us programmers together as comrades regardless of skill level.
If you don’t work for/with raging assholes, anyway.
No no , not just programmers, literally everyone that learns (almost)
@@toki2758 mostly are programmers because it's so mentally draining lmao
Nice profile pic
@@infernic15 why thank you, I think yours is great too
The dev to tester relationship is symbiotic in nature. The dev says "any issues should have been caught in testing", the tester says "well this wasn't my code anyway".
Part of the problem is, many Devs can't handle criticism well and just say "nah it's fine, that will never happen" ... Just to act all surprised Pikachu-face later. And on the other side of the medal many testers can hardly read or write code themselves.
@@skillaxxx The best bugs come from management's not having a clue how things work.
I have no idea what I’m watching
I have no idea what I'm commenting
@@Aliennnaa I have No Idea What Your're Replying
Lol
I have no idea why I am commenting
I have no idea what I am writing.
As the senior guy, I can tell you this was inaccurate. No way was the senior guy wearing pants in real life.
ROFL!!!!!!!!!!!
LOL
I agree
This is actually true, my dad working in quarantine doesn't wear his pants while working
LOL!
Yesterday I was in a meeting and a more experienced back-end engineer was going on how it made more sense to do a certain thing X way, I was like “yeah, that totally makes sense! We should do it that way”. After I closed the meeting the first thing I said to myself was “I have no idea wtf he was talking about”. This is too real omg
Ask him to go through it with you and ask some stupid questions.
You might actually introduce some questions he overlooked and youll get a better understanding
I know this is a skit but....this actually does make me feel better. I legit was getting depressed and in kind of a dark mindset cause I was having trouble fully understanding programming in my programming class (my current teacher makes us do it all on our own alone and no helping eachother at all) but seeing that even in the feild and higher up coders have trouble understanding actually helps me out a lot.
I can code fairly well in python, html and css....I just don't understand it very well when I read it back. Hince why I would get stressed and depressed in my classes. But again this video helps ease my worry some and makes me feel better knowing I'm not alone in the confusion. Thank you.
Takes experience... experience takes time and exposure. You will always drink from the fire hose in the beginning... then years go by and you look back in disbelief at what was a challenge back then is so easy today.
Trick is to try to explain to ur self the codes as simple as possible, this might help u get used to search up errors on google easily
Up your flowchart game boy
Depressed?
Best tip anyone ever gave me is to just go do it! You won’t learn how to code watching someone else do it
How to Pass Unit Test:
- Delete the unit test -
like this :)
*taps head* the test can't fail if the test doesn't exist
@@chrisstroud1915 touche plus your senior engineer won't complain when he himself doesn't know what you did
Lmao
AI have figured out long ago that the best way to not fail at something is to not do it. We must simply follow their example.
Compiler: Warning!
Every dev: Must have been the wind
Lmao the windd
Compiler: You shouln't do that.
Some devs: override.
Is this an Epic NPC Man reference?
@@refreshingmint9663 Skyrim reference
I mean.. if it still runs..
Honestly I feel so relieved after seeing this and reading the comments. I have been a decent student all my life but ever since I started studying Computer Science I thought I was stupid and I feel like this every time I try to learn and do something new
There's nothing wrong with being stupid, just keep trying anyway and you'll get there same as anyone, and not even that much slower. The best (male) marathon runner in the history of the world is less than twice as fast as Chelsea Clinton.
As a software tester, not an actual dev, this makes me happy cause I often don't know what I'm looking at when devs reference "simple" code. Makes me feel like maybe the devs forget how it looks when you haven't been deving the same area of a program for years
"If you can't solve the problem create a world where the problem doesn't exist"
Engineer thinking, I like it
The workaround method. A true classic in engineering.
That's just solving the problem with extra steps
@@dsdy1205 It might seem like it, but it really isn't. There are many unsolvable problems that disappeared by simply inventing a different method that just navigates around it skillfully. The world of math is basically just that. "Oh, you can't prove that a series converges towards a certain number? Well, here's a series that is always bigger and knowingly converges towards that number, here is one that is always smaller and also converges towards that number, so logically your series must also converge"
Things like this are commonplace in math and engineering. You just take the unsolvable problem, ignore it for now, work out a solution for the bigger problem and then check back to see whether it is still necessary to solve the problem or if it just doesn't have to be solved anymore.
@@GermanTopGameTV Yeah, I understand what you mean with workaround solutions, it was more of a tongue in cheek observation that by working around it, the problem is in skme sense "solved"
😂
*deletes the test to pass the build*
The ignored error: "See you in production in 1.5 years, bro"
Hahahaha this!
By that time he would move to another job with 30% pay increase and leave this shieit to Bob who got 30% pay increase and who will spend 3 weeks and 42 monsters on it. The only problem is that the original dude in new job will be fixing the Bobs shiet too. That is essentially senior dev now.
ROFL true
So true. We've had a couple of those in payment logic, now our code changes require tests, and reviews need to flag inadequate testing.
Internet Explorer enters the chat
I’m glad you’re going to do this full time. You’re good. Great video❤️💪
I've been a junior DEV and I'm currently a senior DEV. And I will tell you, this is very accurate.
This is totally unrealistic. No way the junior dev actually ran any tests.
I’m a junior dev who changed one line of code and stuck on a failed UT for hours today. Then CZcams brings me here. What a nice day.
Jajajajajajaja
Managers are doing themselves and their jr developers a disservice if they're not requiring their developers of all levels to write and run their own tests. Writing code thats testable is a skill I am surprised to find lacking in even sr developers who interview with our company
Im a junior and i have not only to run em, but to write em as well :p
When I have studied Computer Science, I have learned how to write Unit Tests in my first semester.
Don’t know where all the „what is an Unit Test? What is that good for?“ guys have learned programming.
I have found that being able to calmly read and confidently work on something that initially leaves you completely dumbfounded is an invaluable skill.
Sometimes making management think you are working when in reality you are just moving text around on a screen while they pay you $$$ is an invaluable skill too.
I have this skill, but it is invaluable only if you can afford to take your time. Otherwise, "calmly read" goes down the drain ha ha...
Thanks for your comment.
Learning english now, and i calmly read your comment... I agree, man...
@@dimitristripakis7364 i got the skill of calmly reading in the not so calm way by doing my review assignment from a very strict professor an hour before class
This is the best thing I've seen in a while thank you thank you😍😍😍
Loved the insights, looking forward to more videos.
as a musician i have no idea why i watched this
That's because you are Brazilian
Vincent Lam that’s a ip grabber link
Lol samee
To comment on it and get recognized?
@@glaucovillasboas8212 ...?
Before writing code : "How to make this code works? I have no idea"
After the code works : "Why my code works? I have no idea"
I just finished a program now. Ugliest piece of spaghetti I ever wrote, but it works. I'll sometimes review old projects of mine, and wonder, "How the hell did I even get that far?"
You start to become a good programmer when you start to know what you're doing, for that, the best way i know is coding an actual compiler, this makes you learn almost everything about how it really works in the back
The latter is far more dangerous than the former.
@@nenrikido2903 But we are not god like programmers like terry a. davis...
@@uohwhoru3473 wut ? you don't need to be god like programmer to do that lol. Why are there still stereotypes on low level stuff being hard..? it's actually simpler since it deals with less stuff and u have less stuff to remember. It's just very time consuming but that's all
As an accountant, absolutely relatable. I do a work paper where Shit don’t add up and I have no idea wtf I am doing and submit it hoping my reviewer can sort my shit out. And then the reviewer would look thru my work and have no clue wtf they are reading.
I have never coded in my life and know nothing about coding or that type of industry but wow that is relatable in a spiritual level
If you delete enough test cases, your test suites will pass every time.
We updated one of our old microservices recently and during this update we trashed almost 90% of all testcases in this service (most of them just because we did not understand what they were supposed to check)...
@@raevar9779 diff the two versions and apply the changes one by one until you figure out what the testcases do. it's a braindead process. you can write a script to do it.
Which language he was writing code in ??? And waht is your sallry
@@marlonaviz9975 Finally someone who gets it. The best testing is in the real world. That means deploying as quickly as possible without wasting time on test suites. Real testing is done by -users- surprise unpaid QA.
@@keshavgupta6549 python
1 Year later:
*The junior engineer:* Who wrote this crap? Oh wait... it was me.
reality is often disappointing
Spider-Men-pointing-at-each-other.jpg
As someone who progressed from junior to senior in the same company... I can confirm this has 100% happened to me.
Exactly 😂😂
I get lost in my own code the very next day...but in seriousness maybe a week of not looking at it and im like wtf is this
Cureently learning to code and to peer code review. Accurate.
This is great! We have this happen all the time. Should do one about a code reviewer that nit picks everything request a ton of changes all the time.
As somebody who reviews all the pull-requests of the juniors I can tell you that this is 100% accurate
That is not reassuring
what’s a pull request
@@chad3558 ah, a software engineer in their natural habitat ;)
Well I guess we're all fucked.
@@cristinawentz I guess it is for juniors?
Teacher: How does you code work?
Me: It just works.
Dream Collector oh Todd
Bethesda approves
*KING CRIMSON*
Overused
@@rionacko748 I guess thats why it came on my mind.
Just had a sprint review where I mentioned we need to be better with our PR reviews. I have seen this multiple times, but having it popping up on my feed again now really was awesome :)
It really matters if you have dedicated testers or not and if you push straight to production and if failure would be critical.
The commit message and branch name are spot on.
And that's how CZcams algorithm was made.
this is underrated comment, srsly.
Yes. The people, who toiled on this algorithm, perhaps, understand better the algorithm than you. Maybe, they wanted users to interest in different topics.
I mean it's not weird. More than one people worked on that. They could create more complex algorithm than you can expect.
@@nazariistarikov7930 chill your fucking arse mate
Hi Hubert!
Lmao
A very small video solved my big question hanging over my mind for long. Thanks, from a Jr Developer.
Thanks for the video!
I get more confused when my code works than when it doesn't work
Several times I've run into some weird problem that suddenly appears and has everyone stumped. Then, someone finds the golden clue, we figure why it's not working, and I ask the big question... How did this EVER work? And none of us knows.
There's nothing scarier than code that works.
@@drewmandan *appears to work.
Code doesn't work until it's been in production for a year and the bugs have stopped flowing.
Truly this is the more scary of the two.
when this happened, my brain goes into "yep humanity are doomed, skynet is upon us"
So true. Or a case of "customer probably doesn't need that feature anyway", delete the line which fails
@Portland Native idk man. this is what I'd do if my code doesn't work after I do a ritual on it.
@Portland Native Nah half the time you don't really understand your own code, but since it works why tf worry about it
He didn't delete block of code that failed the test. He just deleted the test that failed.
Customer?
@@yahya3683 Who the fuck do you work for that you don't need to understand your own production code? If it's web development, sure but for most other things you can't get by like this
Commit statement is 'fix_shit'🤣. LOL. A very concise and nice video showing coder's work. Keep it up
"Its someone elses problem" - Is the best mantra
"I have no idea what I'm reading" perfectly describes my thoughts when I go back and look at old code I've made lol
I took 2 weeks off my current project and I'm already regretting it, lol. Before I took a break I knew exactly what was going on. Now I'm sitting here like a caveman struggling to read my own code.
@@smokinamby Can't agree any more, taken a break for the past 2-3 weeks, I already have anxiety about being lost in my own code and it''s a mini project too lol
Write literal paragraphs of comments
Write legible code with good variable names, don't i j k x y z foo poo everything
Writing comments is against the internal style guide at my company. My first PR i got told to remove all comments, apparently code should be self-documenting via method and variable names
@@VitusAvitus what the fuck kinda company is this???? Good code has more comments than code itself! So every new person has to figure out what the hell it is the last guy did? You gotta look for other companies man
I thought the senior engineer was gonna say, "I have no idea what he's doing." 😂
I though that too bro😂😂😂😂
sameHAHAHAH
Haha same dude
Me too. I think it would have been far more accurate 😂😂
hahahahaha same
This is just too funny and reassuring i’m starting my first job as a tech consultant intern at a big shot company , i was so nervous until i saw the memes 😂
Your videos are so good and it connects to software engineers very much
10 lines change: yeah you have to fix 20 things here.
500+ lines change: LGTM!
Real talk right here
Because you never get the point, what's going on in this 500 lines change, so if it's not broken, LGTM!
Bikeshed story fully applies here
Unless it's 500 lines to fix 2 issues 😂😂
this guy codes
As a senior software engineer myself, this is 100% accurate.
Lemme get like 50$
really?
@@sweetmelon3365 its more about juniors actually, who are doing crazy things, you can't review every single line and also do ur job ;p
@NorthernCaliWay It also depends on how much time you can spare reading the code. Juniors often have a very... interesting... programming style. Doesn't mean it doesn't work, but it takes that much longer to understand what the code is doing.
At the same time, you can't just decline everything the juniors output, which leads to the "I have no idea what I'm reading... lgtm" situation.
Well, idk but i feel like if I don't get job soon enough I will end up on streets although there is no situation supporting my statement. I just know either be best Or die and if I hang around in between no one cares about it, I still have no idea after putting such efforts learning so many languages from soul, interviewers still reject you and on the other hand Some under qualified people sometimes make millions. My uncle is grade10 fail, he's our rival anyway, so i am putting it out. He is so underqualified and makes almost double than a software engineer and he can freaking afford iphones which are so freaking expensive here than in any other country. BTW I hate iPhones, Mac and ios. I don't care what can he afford, all I care is about howw can he afford?
3 years laters and i finally understand what he's doing
Same in smaller companies:
Boss within seconds after my pull request: "nice code, works good"
somewhere on the live system a testing output I forgot to remove pops up
Boss: "WHY IS THIS LIVE??"
Me: "But you approved the code?"
Boss: "oh.."
Boss: “But you’re still fired”
Hahahaha
@Дмитро Григор`Єв you're not moving responsibility though. It's the reviewers responsibility to make sure that the code gets send back if it's not ready to go live
@@sqfzerzefsdf coder > reviewer > test phase (in this phase end for look on your code) > QA checking > pre prod > QA checking > lead checking (check is work as on plan) > manager checking (if lead ok then ok) > go live > selected user checking (sometimes unknown error will found on this section, that should not happen if user follow what instructor telling to them, but sometime they have own imagination of system... ) > user
Well is on my office doing it every scrum task 😂 long long way until is done.
Exactly. Superior will never take the blame
Junior Engineer: *fails a unit test*
Junior Engineer: I'm gonna do what's called a pro-gamer's move
@@markj2093 Just curious, how off-limits do you mean? As in they can't write or modify them, period? How would they learn to unit test real code?
@@carlosmoreno9987 currently working as an intern in a big company and they trusted me with the test code. Currently writing an integration test for one of their projects. Don't know if it's right but it's hella fun lol
@@42war_pig31 I work as a senior engineer at a company and a big part of my job is reviewing others' code and providing meaningful feedback. I do get that this video is a joke and it made me laugh so hard but it seems like the commenter I was replying to was taking it seriously. Testing can totally be fun because it gives you that extra confidence that something is working right. It's also fun to find a bug and work with the dev who submitted it to get it resolved.
@@markj2093 i bet you are a good employer and fun to work with
*pro-gramer's move
As a young architectural professional who's learning Revit more and more each day, this makes figuring out why something doesn't work in Revit look like figuring out why a round peg doesn't fit in a square hole.
I’m learning JS now and for some problems I’ll look at the solution and think, I have no clue. This is comical and comforting.
As someone who only started coding recently (< 1 year), this is so reassuring coz I feel like this everyday 😂😂😂😂
Dont worry it doesnt go away
Lmao I have a 3.44 gpa about to graduate and I have felt lost every single day 😂
I am a Thai boy Who like computers ❤
@@ducktrapper483 You never know what the hell you are writing
Its the same for everyone :)
I watched this in college: funny.
I watched this now that I have a programming job: HILARIOUS
ON POINT
Totally me rn, I have no idea what the hell im doing
This is me
Did college help or just waste of time for piece of paper and new friends at best?
@@FirstnameLastname-my7bz you need to experience college to realize its not all that great to graduate and stop there
@@SuperSpeed52 already did
This makes me feel better going into this kinda field
So glad I only need one programming class for my env engg degree.
Deleting a failing test had me actually bust out laughing. That spoke to me on such a deep level.
same. everytime a test fails, I look through a similar test case, ask myself why mine is failing, in the end delete it and hope for the best. :D
It can't fail if you delete it or comment it out XD
It's the spiritual side of the job
Me: oh, looks like this file i'm changing has zero tests, so i'll just a general test here and one for the change I just did.
Reviewer: you left a file with 60% coverage and we are expected to have at least 95%.
I was literally looking for the error of my Java Code for 30 minutes
The error: }
HAHA true
Noobs don't read the error output which literally tells you what's wrong. Read the errors..they help. When in doubt, skip to the end of the error to get the gist.
In C++ it is worse. The error: ;
@@thisisayoutube3811 i have no idea what I'm reading
🤣🤣🤣🤣🤣
One of the main reasons why i hated coding so much back in highschool was because you can never learn enough to not be confused. Even performing simple coding requires you to get help from somebody or somewhere, and then when you follow that tutorial word for word you still end up gettin an error messsage which requires you to run more tests to see what is causing that error.
Litterally me rn my parents want me to major in CS but even in highschool I cant even do basic java tasks….
this video is fun to link to people in pullrequests
"AssertionError: False is not true"
Mmm... Yes... The logic here is made out of logic
Hmm yes the integers here are made out of numbers
People die if they are killed
Ah yes brain is made out of brain
Does that mean false is false or the statement is not false but is actually true
every 60 seconds in Africa...
You know it's gettin real when they don't even pull up stack overflow
They do, but In their mind
Stackoverflow is not the best tool out there at all..especially in a professional standpoint.
You know it’s real when they code with vim
@@yulfine1688 Then what is?
@@NicosoftNT your coworkers whatever networks you have built. Numerous other sites. Its not a bad site but its good for amateurs to learn and understand its not perfect its too easy to mess with and change and not everyone on their is some professional programmer. Its not always accurate and finding the solution yourself is generally more important. There's a reason why companies have so many others plus leads and testers as well for large programs. I can guarantee you they don't go onto stackoverflow and search for their problems and solutions. If you need stack for those kind of positions why are you working that high up and how did you get hired.
THIS WAS SO GOOD
I felt this on a deeply personal level.
at my first job merge requests were heavily scrutinized and could have dozens of comments and requests for major changes that could take weeks. since then i've worked at places where code reviews were quick, and at places where they were just rubber stamped. i've come to really appreciate the brutal code reviews i got at the first place.
If addressing a code review takes weeks, there's something wrong with the process.
It usually means pull requests are too large and should be broken down into smaller steps (so that the submitters get an early warning before they completely paint themselves into a corner).
the important thing with code review - in my view - is to know when to stop.
there is a point where you reach the "gold plating" phase, and addressing remarks may still increase code quality, but the improvement no longer justifies the time spent on it.
it's a matter of finding the sweet spot between two extremes.
Code reviews where I am tend to be an off an on ~3 hour affair. Once people are done with the source code, they put it up for review and check for comments every now and then while writing out tests and doing some last minute manual testing. It's actually a kinda chill after lunch kinda thing. Nice way to end a Friday....
I also prefer the brutal reviews. I learn more and make better code. Rubber stamp = crap I gotta fix later
Ya a friend just told me: "A review with 15 lines of code will have 25 comments. One with 1000 lines of code will have 0 comments."
Reminds me of a Stanley Kubrick vid I saw a while ago. He'd do a brutal # of takes and told the actors 'next film you work on, you're gonna miss that'
After this LGTM, if build breaks next day it's LGTM - Let's Go To Meeting 😂😂😂
Put them in a same room, now they are LGBT
@@KangJangkrik not funny, didn't laugh
@@afruit6720 nice
haha just too good.. 😂
Lmfao!😂
So I’m getting my self into coding and I’m still fairly new and even though I don’t really know what’s going . I find your videos still funny 😂😂
I so did this as a Senior Developer. Approve anything as long as it passed the build checks and didn't look stupid. I wasn't about to go check Jira to see what the code should actually be doing, I have my own work to do.
I just graduated with a BS in comp sci, glad to hear nothing is different outside of academia
Yeah, in academia they skip the bs and don't even review code. At least startup and big companies will have the facade of code reviews.
Yeah don’t worry dude. Finished comp sci and myself and a bunch of mates went into non dev jobs because we considered ourselves as having scraped by despite having good grades. Then the one member of our friendship group that was by far the worst coder got a job at an Android Dev firm and was praised as being one of the best coders they had seen in years
It’s bullshit all the way down
@@chameleonedm lmao
BS like bullshit?
@@chameleonedm maybe he got better?
As someone who works in QA and always seems to find issues that should have been caught by unit tests, this seems incredibly accurate.
Same as a design lead who regularly checks whether her team's features got implemented as designed. "WTF even is this? How did this get past code review?" This explains a lot.
i don't unit test😆
As a dev who always seems to fix prod issues that should have been caught by QA, that probably could have been found in unit tests , this seems accurate.
This is 1000% accurate
Tests are formloosers, thats why we have qa.
As an MET student who is studying CAM, this is too accurate. It’s a lot of clicking and praying for nothing to go wrong.
I love you man! You make me feel less lonely 😂
Thats Microsoft when they make an update for windows
I am a programmer
my wife is a occupational therapist
both of us watching
me - rolling in laughter
wife - I have no idea what is so funny
me - laughed even more
Me: Not understanding why you find it so funny
You: *laughs even harder*
Programmers wife says to programmer "Go to the shop and get a loaf of bread, and if they've got eggs get a dozen".... the programmer comes back with 12 loaves of bread! 😁
@@crazydavec3861 Question...how can the programmer come back?
1. get a loaf of bread function is outside of if statement
2. if (got eggs) => get a dozen (exception thrown, undefined dozen method)
3. also, if no exception at step 2, got no return from shop function (programmer probably stuck at shop, need help)
hmm...does programmer's wife have other functionality other than passing data to programmer?
else need to enhance programmer's wife XD
Weird, I swear If you started reading medieval stories (idk if I spelled that right) for like a month you'll just start saying the phrases they say lmao. like what you surround yourself with is what you turn into.
This video spoke to my soul
This is so extremely accurate
That's so true. LGTM stands for "I've got better things to do than reviewing your PR"
This is eerily comforting as a CS student who often has no idea what he's doing
I'm in my senior year and am questioning my life choices but this vid eased the pain just a bit
@@epicninja3 yup same. My last quarter as well. We’ll be alright my friend
@@Jmoss7 in my first year and i have no idea why my simple code doesn't work but the example worked =_=
@@epicninja3 I graduated and still trying to get in thisfield and feel like I know nothing. maybe, I really don't but can't blame it on anyone but myself for not putting enough work :( I feel like I am just re-learning or reviewing basics of coding and never jumping to the next level.. just ranting...at this point ah such a waste of time...
@@HarimaKentaro Yeah it can be hard to put in the work some times. Idk if there is a particular area of CS that interests you but I would try to hone in on a niche if you can. The CS program at my uni is very general which is kinda nice in a way, but I feel like it may bite me in the foot cause I know a little about many areas but I am not an expert at anything.
This is spot on.
Holy shit, I recently started working in a big tech company and this is so accurate it caught me by surprise
As a student, I can totally relate to removing failed tests and hoping the grader will not notice something missing.
As a senior developer a deleted unit test without removal of corresponding production code automatically force me to choose "-2" in gerrit.
Oh, a grader will usually notice, because they (A) know that the problem should be (and probably is) solvable with all the tests in place an passing, (B) still remember why they put these tests there when posing the problem as an assignment and (C) expect that at least some of their many students will try that, so thus they watch out for it.
When doing code reviews on changes to real production code, the reviewer often has neither of these advantages. For all they know, the tests might (or even might not) have made sense back when they were added, but who knows whether they still make sense now or will continue to make sense with the to-be-reviewed change?
Where I went to university it wasn't about whether ur code worked. It was more about whether it:
1. Looked like it worked (I.E Pass a tired TA skimming through the code at 10 lines a second the night b4 their marking due date, since they're busy with their own course work)
2. Passed the automated tests setup by the professor that the TA ran ur code through
Then there were the assignments that gave more free reign where u lose marks for not adding in enough high-quality features... The hell u want me to do in 1 week and 4 other courses?
@@1ProAssassin poor boy you have to many on your plate so you shit in one place rapidly and expect no one to notice.
Wait until you will face someone that actually knows what his doing and not only expect you to pass all the 2k unit tests but also the 1k functionnal tests and add your fare share of testing too.
There is a moto: you do the thing great or you don't do it at all.
There is no shame to don't know but you have at least the mission to get what you are doing and trying to propose resolution.
I think in this job if you are not able to take time to get what's the issue (and I mean at least a day a an half day only focus on this) before reaching help or capitulate, switch your career path right away.
This is for people we will to solve issue, else go to business analyst. You will count flies in meeting all day but at least your brain won't be to solicitate
What
The worst thing is when it’s you who checks their code in a grouped Skype meeting. "Ummm.... Yeah.... Oh, I see... Let me, let me... Hmmm... I don't see a problem... but you say its not working?"
Oh guys my internet’s gone down again. Brb.
You guys don’t use Zoom? Skype, really? Not even MS Teams?
@@babybbbb Skype can crash using any VPN, activating and deactivating it.
You can fake a bad internet connection
@@antispiral4362 but why not use Zoom?????
@@babybbbb Read the last line of the previous reply.
This gave me confidence now
LETS GET THE MONEY!!!
Fr, though I joined with a company as an entry level developer, no professional experience, and finally got to a point where I understood the project enough. That's when they said I was one of the leads on the project.
How everyone thinks programmers code:
*Super cool green stuff on their screen and typing code as fast af*
Reality:
70% of the time copy and pasting
20% of the time thinking why am I here, just to suffer.
8% of the time being dead both physically and mentally
2% of the time actually coding
Now I'm afraid to take computer science as my course 😢
@@vscgsecsbarecigsifp9424 that's included in the first 70%
Cuz essentially googling is a part of copy pasting
First year computer engineering, should I change my course asap?
@@hellwalker4257 if it has engineering in it you'll be fine, as long as you dont do drugs
@@vscgsecsbarecigsifp9424 what do you mean by "if it has engineering in it"? Am I gonna end up sitting in a chair, doing stressful work I'm untrained to do, totally relying on a chance of finding solution online, all the way balding to my death?
I needed this so badly right now. The other night my imposture syndrome was on another level. I wanted to walk away from it all. So I did... I didn't quit, but I went to go fix something else in the garage and that gave me the boost of confidence I needed to prove I CAN figure things out. And then I was able to complete my solution.
I can relate, this monday was probably the worst I ever had in a long time coding. Nothing I was supposed to do worked, just errors that made no actual sense, my anxiety broke me.
The next day I solved one, the next one I solved the rest. By Thursday I was done with everything and was feeling happy again.
This stuff is painful man
@@Salieri01 That feeling when you figure it out though.
@@antattackBAM a high like no other.
@@antattackBAM feels great man
@@Salieri01 That feel when you have a bug and can't figure at what it is after looking into it for many hours, and just look at the void thinking why you chose to do this job xd
I love how that's clearly VIM and he's using the mouse to select text... sacrilegious
This is so true. I’ve taken an internship at a large airline’s IT department and we were working on one of their mobile apps and had this happen too, fixed the glitch a month later (whoops)
When the code doesn't work: What?
When the code works: What?
To junior engineers : How the hell you want us to review a 5k coding lines...
The best part : they think we REALLY reviewed it 😅
Omg yes, and then somehow I got in trouble.
The part drives me nuts when I start a completely new project, because I _know_ that before my first PR, it's going to have to be a few thousand lines of code (just to get to the point of vaguely functional).
At that point, I try to divvy it up between reviewers. Because there's zero way for someone to review the whole damn thing.
@@jimbobjones9330 There really isn't any situation in which a PR should be so massive that you need to split it up to different reviewers. Even if you're starting a completely new project, you can still easily split it up into smaller chunks. Focus on creating the API first, figure out what end points you'll need and what data needs to be returned.
Not sure how you manage your front end, but most component-driven frameworks shouldn't really require reviewing more than 1 element/page of the application at any time. Which is super manageable.
@@SpencerFcp Thank you! When I see how many developers here admit that they do exactly what is depicted in the video, I feel quite sad...
@@jimbobjones9330 Reviewing code is a maintenance job for code in production. If you are starting a new project from scratch, code reviews are fairly pointless. However, design reviews are quite useful at that stage, but those don't happen in terms of merge or pull requests.
Happy to say, since I watch this video about 4 years ago, finally I got my first senior title and I can write "LGTM!" review on my colleague dev PR lol
I don’t know why I keep watching this video. Is so satisfying.
I’m not a programmer, I haven’t watched any programming videos... but the algorithm has chosen me. All hail the algorithm.
@@nevinkuser9892 thanks, I feel so speshull!
Maybe it’s a sign that you should pursue programming
maybe_it's_a_sign_you_should_pursue_programing = input("What do you think? ")
@@Eric-dd8bk Take my like. You’re very clever lol
@@keyanaclark526
statement = "Thank you"
for words in statement:
print(words)
Thank
you
"LGTM!" famous last words
Lol
Hopefully.
Says Elon Musk
Wtf is LGTM
@@christianmata5746 looks good to merge?
Team work as it is.
This clip relieved a bit of the anxieties I have with coding. As I’m also learning. And I still have a feeling I don’t know what I’m doing. 🤣
Ah you forgot student engineer: “I have no idea what I’m doing”
Im taking Discrete math in CS and yeah ... this holds true...
Me: Writes code
Boss: Nice work. *WE* did it.
Me: *looks at avatar*
Lmao
Omggggg so legit
once you change that pfp it won't make sense anymore
@@kjl3080 mike wazowski is staying
Your videos are brilliants
this explains so much.
this is so true, when I worked at a small start up, they reviewed and corrected every single detail of my codes, otherwise, when I worked at a big company they didn't give a shit and just approved everything I've done, as long as there're no conflicts.
You should try a large games company. A common pattern there is to have a dedicated, full-time "merge b1tch"* who'se sole job is fixing all the conflicts in the build. The actual feature and gameplay developers are far to busy making new commits with new conflicts to do any actual rebasing and merging themselves.
* sorry if the term is offensive, but it is they were desribed to me :/
@@CJTongue i hope to live in a World were bitch isnt offensive
@@sayem1337 freedom of speech only when you like it, eh? Snowflake.
@@CJTongue I feel like in a large company having someone full-time in charge of reviews makes sense, but having someone employed full-time to just clean up other people's shit results in a lot of code being rewritten by a guy who doesn't know anything about that particular area. Honestly, if someone other than the dev is having to unpick conflicts you're in for a rough time.
@@traveller23e Totally agree, and I can't imagine it is anything other than a source of bugs. I can see how it starts though with a 'how can you go faster' 'well I keep getting stuck by everyone else merging and creating conflicts' 'OK we will get someone to take care of it for you' *problem intensifies*