The fastest way to iterate a List in C# is NOT what you think

Sdílet
Vložit
  • čas přidán 14. 09. 2022
  • Check out my courses: dometrain.com
    Become a Patreon and get source code access: / nickchapsas
    Hello everybody I'm Nick and in this video I will show you all the way you can iterate a List in C# and then show you what is by far the fastest and most memory efficient way. You might have guessed where this is going :)
    Don't forget to comment, like and subscribe :)
    Social Media:
    Follow me on GitHub: bit.ly/ChapsasGitHub
    Follow me on Twitter: bit.ly/ChapsasTwitter
    Connect on LinkedIn: bit.ly/ChapsasLinkedIn
    Keep coding merch: keepcoding.shop
    #csharp #dotnet

Komentáře • 408

  • @capsey_
    @capsey_ Před rokem +123

    Nick should get a shirt with "I Stan the Span" printed on it

    • @nickchapsas
      @nickchapsas  Před rokem +31

      Coming on a t-shirt near you twitter.com/nickchapsas/status/1523025560774987777

    • @joshstather3543
      @joshstather3543 Před rokem +9

      @@nickchapsas Coming on a t-shirt??? 😳😳

    • @foamtoaster9742
      @foamtoaster9742 Před rokem +3

      I would buy that

    • @Zatrit
      @Zatrit Před rokem +1

      WriteLine'd on it*

  • @ooples
    @ooples Před rokem +8

    I love the humor of using 80085 as your seed and I'm not sure if anyone else caught this old calculator dirty humor

  • @ristopaasivirta9770
    @ristopaasivirta9770 Před rokem +104

    Great benchmark.
    Good that you explained that the parallel versions are most likely faster when you actually do work inside the iterations.
    It always distracts me when you say "half the speed" when you mean "half the time" (ie. double the speed).
    I know it might be a language thingy, but it is really confusing at times.

    • @nickchapsas
      @nickchapsas  Před rokem +73

      Oh damn you are right. I was thinking it in my head in Greek. In English it doesn't really make sense.

    • @ZeroSleap
      @ZeroSleap Před rokem +8

      @@nickchapsas Oh wait,so you are actually Greek huh?

    • @nickchapsas
      @nickchapsas  Před rokem +13

      @@ZeroSleap Yeap

    • @unskeptable
      @unskeptable Před rokem +3

      Actually I'm not sure we say that in Greek either 🤔 Haha very confused

    • @LordErnie
      @LordErnie Před rokem +30

      He a bit geeky, he a bit Greeky

  • @urbanguest
    @urbanguest Před rokem +7

    Your videos are the best and I have learned so much from watching your videos. Keep up the fantastic work! I've been coding for over 30years and I'm still learning new tricks, thanks!

  • @Zindawg02
    @Zindawg02 Před rokem +7

    I've been a C# software engineer for a few years now and until this video I've never heard of a Span (outside the context of html lol). Going to be looking that up, great vid!

  • @Sahuagin
    @Sahuagin Před 9 měsíci +3

    .ForEach is not a LINQ method it is actually defined on List

  • @GarethDoherty1985
    @GarethDoherty1985 Před rokem +7

    This was a great video. I love your little deep dives into the C# language.

  • @Tal__Shachar
    @Tal__Shachar Před rokem +24

    Can't express enough how amazing and educational your videos are. Keep doing what you do!!

  • @spacetravelnerd6058
    @spacetravelnerd6058 Před rokem

    Great video! I certainly could have used this on previous projects but will make sure it gives me the benefits I need for my current ones.

  • @FunWithBits
    @FunWithBits Před rokem +5

    I like how this channel gives a clear statement on what will be answered in a moment. Example: (1) At 1:12 Nick says, "I'm going to put all the ways to iterate over a list here" (2) This allows the user to pause the video and try and think of ways. (3) Then click play and view the 7 different ways. Its great that something like "Feel free to pause the video and try...." as most viewers know this and would not do it anyway. Side note - I was able to only think of three ways. (for loop, and forearch loop, ToArray().Select(x=>x) )

  • @sergiom.954
    @sergiom.954 Před rokem +1

    That final console output is really good resume to keep in mind the use of iterations in c#. Very useful 👏👏

  • @paulembleton1733
    @paulembleton1733 Před rokem

    Didn’t know about Span(), never would have thought to look, foreach was already heaven, thank you.
    I was taught never add or remove items during a for loop but dd it anyway, then fast forward to writing multithreaded applications and foreach and Span() throwing an exception is a useful indicator of faulty design.

  • @itaylorm
    @itaylorm Před 3 měsíci

    Very detailed and helpful showing you the results of the typical options Andrew ones I had not seen before

  • @surajrohira6384
    @surajrohira6384 Před rokem

    Love these kind of videos, and so well explained!

  • @hipihypnoctice
    @hipihypnoctice Před rokem +11

    Interesting. I could use this to speed some things up. Seems pretty niche for most of what I do tho, but definitely an improvement where improvements can be made

  • @rogerdeutsch5883
    @rogerdeutsch5883 Před rokem

    Fantastic video, great info and very clear. Learned a lot. Subscribed.

  • @jondoty
    @jondoty Před rokem +1

    LINQ doesn't have a ForEach extension method. What's being used in the video looks like the ForEach method defined by List.

  • @coding-gemini
    @coding-gemini Před rokem

    Very interesting to learn this, I could use this in my project. Thanks Nick

  • @IAmFeO2x
    @IAmFeO2x Před rokem +43

    Great video as always! I also did some collection benchmarks back in April 2022, and i found something different than your benchmarks: for loops were considerably faster than foreach loops. The problem in your benchmark code might be that you access the private field instead of using a variable. foreach will automatically inline the field access to a variable, but for does not do that. In my benchmarks, foreach loops on List were 50% slower than for loops.

    • @nickchapsas
      @nickchapsas  Před rokem +47

      It looks like this got optimized in .NET 7

    • @MaxReble
      @MaxReble Před rokem +3

      Yep, made similar benchmark tests and in dotnet 6 for 100k iterations and foreach took 75 us, for took 37us and Span Foreach 24us. Nice to see that dotnet 7 has many hidden performance boosts!

    • @IAmFeO2x
      @IAmFeO2x Před rokem +2

      @@MaxReble Yep, can confirm, too: I reran my tests with .NET 7 RC1 and for and foreach loops are now nearly identitcal in speed. Still nearly twice as slow as iterating over arrays, spans, or ImmutableArray.

    • @aurinator
      @aurinator Před rokem +1

      Should be parallel unless future iterations/loops are impacted by previous ones IMO. Going for the fastest synchronous/sequential approach is a great exercise, but independent iterations are the perfect Use Case to be done in parallel.

    • @marbachdaniel
      @marbachdaniel Před rokem +1

      It might be a good idea to add a benchmark consumer type to actually consume the iteration result to make sure nothing gets optimized away

  • @kevinmartin7760
    @kevinmartin7760 Před rokem +2

    As an old guy, I want to add that, if you don't care about the order of iteration (and all the parallel examples illustrate this is the case here), you can run the index backwards, which avoids calling Count, Size, or Length on each iteration:
    var asSpan = CollectionsMarshal.AsSpan(_items);
    for (int i = asSpan.Length; --i >= 0; )
    {
    var item = asSpan[i];
    }
    Note that I explicitly declared i as a signed type so the loop termination condition can be satisfied.
    Many of the other examples (not using Span) also fail if the collection is changed during the iteration. The difference is that with the cases that use an enumerator you deterministically get a specific exception, whereas with the Span you just get mysterious behaviour (which is also true for the direct indexing loop).

    • @alexintel8029
      @alexintel8029 Před rokem +1

      Just a couple of days ago, I implemented a backward for loop similar to your example and it used a var for the index variable. I wonder if is it really worth using --i >= 0 ?

    • @kevinmartin7760
      @kevinmartin7760 Před rokem +2

      @@alexintel8029 It depends on the actual processor, but on the ones typically used nowadays comparing the result of a computation with zero is faster because no compare instruction is required. The instruction for the computation (in this case likely a decrement instruction) will set flags in the processor indicating if the result was zero, negative, or the computation produced signed or unsigned carry/borrow/overflow, so it can be immediately followed by a conditional jump.
      If you separate the decrement from the compare, a decent optimizing compiler should be able to relocate them so the conditional jump is still right after the compare, for instance treating:
      for (int i = x; i >= 0; --i) {...}
      as:
      int i = x;
      if (i >= 0)
      do {...} while (--i >= 0); // which can again decrement and conditionally jump with no compare
      instead of the more direct
      int i = x;
      while (i >= 0) { ...; --i; }
      However if your exit condition compares with a value other than constant zero, as in
      for (int i = 0; i

    • @alexintel8029
      @alexintel8029 Před rokem

      @@kevinmartin7760 Thanks for the explanation Kevin.
      I realise the beauty of your original example
      for (int i = asSpan.Length; --i >= 0; ) {...}
      It helps
      a) prevent accessing asSpan[asSpan.Length] which would lead to index out-of-bound error
      b) decrement the loop
      c) test for exit condition

  • @cdarrigo
    @cdarrigo Před rokem

    Excellent find. Thank you

  • @slipoch6635
    @slipoch6635 Před rokem

    Always great info man.

  • @vladkorsak2163
    @vladkorsak2163 Před rokem

    Good point man. Thanks for the video.

  • @redguard128
    @redguard128 Před rokem +7

    It was as expected. Nothing beats the standard WHILE loop except doing things in parallel - which comes with a lot of downsides.

  • @neotechfriend
    @neotechfriend Před 2 měsíci

    As always , thanks Nick

  • @zacky7862
    @zacky7862 Před rokem

    Oh wow! didn't know about this. Thank you so much

  • @miguelfajardo8236
    @miguelfajardo8236 Před 11 měsíci

    What a great video and information for iterating a List !! I think that this works with a List of object that has plenty of properties...

  • @haxi52
    @haxi52 Před rokem

    I rarely work with List, would have liked to see benchmarks with lists of classes. I feel like the results would be very different.
    Also please add disclaimers to your performance videos. Some might get the idea they should be using span loops everywhere.

    • @nickchapsas
      @nickchapsas  Před rokem

      There is a similar performance improvement with other objects. The video does have a disclaimer too

    • @MaxReble
      @MaxReble Před rokem

      I ran the test and on my machine results are as followed (with dotnet 7)
      List
      Iterate_ForEach | 49.71 us | 0.330 us | 0.276 us | - |
      Iterate_For | 40.59 us | 0.241 us | 0.213 us | - |
      Iterate_ForEach_AsSpan | 24.64 us | 0.129 us | 0.121 us | - |
      List
      Iterate_ForEach | 52.27 us | 0.634 us | 0.562 us | - |
      Iterate_For | 41.18 us | 0.477 us | 0.398 us | - |
      Iterate_ForEach_AsSpan | 25.33 us | 0.480 us | 0.426 us | - |
      So, I see a bigger difference between for and foreach as nick does, but the delta of for and foreach_asspan does not change.

  • @Sky4CE
    @Sky4CE Před rokem

    That is awesome! Thanks Nick

  • @beecee793
    @beecee793 Před rokem

    Great video, glad I found you.

  • @stephencollis1453
    @stephencollis1453 Před rokem

    I'm watching this for fun, it's legit fun to watch. Hat's off

  • @Meta0Riot
    @Meta0Riot Před rokem

    Awesome video. Always learn something new.

  • @bmazi
    @bmazi Před rokem

    Extra way: walk via unconditional (!) "for" loop, exit via catching "OutOfBounds" exception. Removes double-checking of bounds, but introduces overhead from exception handling. May outperform if the list is extremely huge (throw cost is constant and doesn't scale with items count).

  • @BadgersEscape
    @BadgersEscape Před rokem +3

    Getting a local scoped reference to the array allows JIT to optimize away the range checks in the loop (technically also unroll but I don't think it does that). It's not possible for a list since there is no guarantee that other code somewhere wont change the length during our looping. But if you have an array, then length is fixed, and you can do a single if-check pre-looping instead of checking the bounds every iteration.

    • @TheMAZZTer
      @TheMAZZTer Před rokem

      Interesting, this should also be possible for any foreach since the collection isn't allowed to change during the loop, but I guess .NET does not implement that optimization (yet).

  • @tobyjacobs1310
    @tobyjacobs1310 Před rokem

    This is so much nicer than my in a pinch method:
    Compiled reflection accessing the array, then use that and the count to get a span. Probably a smidgeon faster too...
    Spans are amazing....

  • @franciscovilches6839
    @franciscovilches6839 Před rokem

    Very interesting. Thanks for this!

  • @dawidopalinski702
    @dawidopalinski702 Před rokem

    This is the best free software Ive seen. Respect.

  • @jongeduard
    @jongeduard Před rokem +1

    Probably the absolute winner: on Stackoverflow I found an example of doing parallel work on a Span, but it involves unsafe pointers, since the Span type itself cannot escape to the heap and therefore Parallel calls on it are normally not possible.
    I searched for this because I was curious why this ultimate combination was not metioned in the video.

    • @pedroferreiramorais9773
      @pedroferreiramorais9773 Před rokem +1

      You can actually combine Parallel.ForEach and Span without pointers. I did some benchmarks and it was faster than all of Nick's implementations @ 1 million elements.
      The trick is using Partitioner.Create(0, list.Count) and passing it to Parallel.ForEach along with a closure around list that takes a Tuple as parameter and marshalls list to Span, then slices it using the tuple and finally iterates over it.

    • @jongeduard
      @jongeduard Před rokem +1

      @@pedroferreiramorais9773 Oh great :), I really have to dive into that to understand how that works.
      Let's say that a very simple solution does at least not exist yet.

    • @pedroferreiramorais9773
      @pedroferreiramorais9773 Před rokem

      @@jongeduard well, you can create an extension method to encapsulate all the logic, but it loses much of the performance gain. It can still be better than sequential span iteration of very large lists/arrays, but if performance is the main concern, you often have to get your hands dirty.

  • @chiragdarji1571
    @chiragdarji1571 Před rokem +3

    hi, great video as usual. Do you take topic suggestions? parallel.foreach vs parallel.foreachasync pls .. :)

  • @KineticCode
    @KineticCode Před rokem +11

    i think the unsafe part is fine and expected, foreach breaks if you add/remove elements during a loop as well.

    • @RahulSingh-il1xk
      @RahulSingh-il1xk Před rokem +2

      That's true. But what if we mutate objects of the list. Say, a person from List while looping. Foreach allows this - will this span approach too?

    • @PetrVejchoda
      @PetrVejchoda Před rokem

      @@RahulSingh-il1xk Obviously not on values that you access during the iteration. What I am interested in is what happens if I mutate values, that are not accessed during the iteration.

    • @KineticCode
      @KineticCode Před rokem +1

      Guys I think you can mutate objects :) its not a readonly span, just a span

    • @Crozz22
      @Crozz22 Před rokem

      because foreach breaks if the list is mutated then they should just make foreach compile into the unsafe part

  • @ivaniliev93
    @ivaniliev93 Před rokem

    Amazing stuff, thanks!

  • @docleoyeo
    @docleoyeo Před rokem

    This helped a lot thank you

  • @jackp3303
    @jackp3303 Před rokem

    There is one more way to iterate - using SIMD (Vector), which has lowest readability, but probably will have the best performance, because it's accelerated on hw level and CPU takes n items in processing at one CPU clock.

  • @ayhamala3ma189
    @ayhamala3ma189 Před rokem

    Brilliant 💪

  • @matejakendereski4264
    @matejakendereski4264 Před rokem

    Everything is cool! Thanks!

  • @user-zh3el2yr6h
    @user-zh3el2yr6h Před rokem +18

    Nick is a legend. Integrating "easter eggs" like 69, 1337 and 80085 always makes me smile

  • @Evan-zj5mt
    @Evan-zj5mt Před rokem +1

    Watching your videos makes is very humbling and makes me realise that I'm absolutely shit at my job!

    • @nickchapsas
      @nickchapsas  Před rokem +4

      Nah trust me you don’t need to know 99% of the stuff I show to be good at your job

  • @petrusion2827
    @petrusion2827 Před rokem +5

    Calling it before watching the video: CollectionsMarshal.AsSpan()
    Edit: Called it. I would've also liked to see a benchmark which uses the list cast to an IEnumerable, then the IEnumerator would be an interface variable instead of a stack struct which would slow things down because of dynamic dispatch.

    • @nickchapsas
      @nickchapsas  Před rokem +2

      Hey I can see that you skipped forward 👀

    • @petrusion2827
      @petrusion2827 Před rokem

      @@nickchapsas Oh yeah I didn't have time to watch the whole video from start to finish, I used CZcams's 10 second skips to go through the most relevant parts, but only after I made the comment :D
      Nice vid for sure

    • @QwDragon
      @QwDragon Před rokem

      @@nickchapsas you haven't shown foreach on IEnumerable in the video.

  • @SergeDuka
    @SergeDuka Před rokem

    To span a loop into a 13 minute video, that's what I call a great job! lol

  • @22Ericelcuervo
    @22Ericelcuervo Před rokem

    Hi, great video! its so usefull. Thanks. I have a question, how can i implement it in async method? what is the best practices in async?

  • @DaveGouda
    @DaveGouda Před rokem

    This was really interesting. I've never seen the AsSpan methods before. I honestly had to look up what a Span was lmao.

  • @QwDragon
    @QwDragon Před rokem +32

    ForEach is list method, not linq method.
    Span forbids only adding and removing of items, but not assigning.
    And also I don't like benchmarks that don't use data. Some optimizer can remove more than expected. You've shown IL, but it doesn't garantee jit won't change smth.
    9:26 How can 1 byte be allocated?

    • @VoroninPavel
      @VoroninPavel Před rokem

      I assume there are cases when compiler (jit) can infer that it's safe to use span for list traversal.

    • @2003vito
      @2003vito Před rokem +1

      malloc(1)

    • @protox4
      @protox4 Před rokem +3

      1 byte is allocated because the JIT allocates, and the benchmark picks it up. That allocation is removed in .Net 7. You can read more about it on the benchmarkdotnet repo.
      It's actually more than 1 byte allocated, but the benchmark divides it by how many iterations were ran.
      [Edit] Actually, the rogue allocation still seems to be showing up in Net 7, but the cause hasn't been looked into yet.

    • @QwDragon
      @QwDragon Před rokem

      @@protox4 Thanks for pointing out is is averaged.

  • @lancemarchetti8673
    @lancemarchetti8673 Před rokem

    Brilliant!

  • @yv989c
    @yv989c Před rokem

    Thanks! I wasn't aware of CollectionsMarshal!

  • @ayudakov
    @ayudakov Před rokem

    Thank you!

  • @GregUzelac
    @GregUzelac Před rokem

    Outstanding comparison. 5 stars

  • @karldavis7392
    @karldavis7392 Před rokem +1

    I use Parallel when the tasks are small in number and heavy. I have an app that does six similar tasks, each taking about 500 ms, and it's great. If you needed 3000 ms instead by doing 3000 tasks that each take 1 ms, the overhead of creating each instance makes it a close call. If it's 3,000,000 jobs that each take 1 us, then I definitely would not parallel.

  • @diadetediotedio6918
    @diadetediotedio6918 Před rokem

    I will give you a little tip, on the List as Span method you can actually use it to modify the items with ref, like:
    var listSpan = CollectionsMarshal.AsSpan(list);
    foreach(ref var item in listSpan)
    {
    // You can modify 'item' here even if it is a struct
    }

    • @nickchapsas
      @nickchapsas  Před rokem

      You don’t need ref to modify the items. You can just modify them. They are still references

    • @diadetediotedio6918
      @diadetediotedio6918 Před rokem +3

      @@nickchapsas
      No, if they are structs you will surely need ref, and if you want to "modify" immutable records too.
      Think in things like:
      foreach(ref var itemStats in item.Stats)
      {
      itemStats = itemStats with { Speed = 10 };
      }
      You cannot do anything like that without refs.

  • @user-lf5sy5mv3l
    @user-lf5sy5mv3l Před rokem

    It was funny when I rolled my eyes before you said “Of course it would be a span” and started giggling 😂😂

  • @brunodossantosrodrigues5049

    How much time did you train to talk so fast and clearly at the end of the video? I really thought that I knew how to iterate... thanks for always taking our code to the next level

  • @mykhailokonontsev3132

    Love your seeds

  • @justengineering1008
    @justengineering1008 Před rokem

    To complete the big picture, You can add Enumerator + While( list.MoveNext()){bla-bla-bla}
    some tests say that it more efficient than foreach/for but not so efficient as a span

  • @parthaf22
    @parthaf22 Před rokem

    Great video. could you make one video on Partitioner?

  • @T___Brown
    @T___Brown Před rokem

    Nice. Ty

  • @aschwinwesselius
    @aschwinwesselius Před rokem

    @Nick, I'm curious if you've ever encounter a Duff's Device in C# and if you would consider it to benchmark it as well. I would be delighted to see it compared to the span.
    Thanks for this video in any case.

    • @MarkusSchaber
      @MarkusSchaber Před rokem

      C# Syntax is much more restrictive than C, it won't allow the original Duff's Device. And, tbh, I'm rather happy about that. 🙂

  • @codemonkeyjesse
    @codemonkeyjesse Před rokem

    Looking at the implementation of List.ForEach I don't understand why this one is so much slower than just the standard for. Is invoking an Action really that slow of an operation?

    • @nickchapsas
      @nickchapsas  Před rokem +2

      Yes and it is also prone to closures that can make the problem even worse

    • @Crozz22
      @Crozz22 Před rokem

      @@nickchapsas what if you make the lambda static

  • @ahmedseada7371
    @ahmedseada7371 Před rokem

    Great Thanks

  • @titiksasanti2205
    @titiksasanti2205 Před rokem

    Thank you!

  • @AaronMolligan
    @AaronMolligan Před rokem +1

    I am only 2 weeks into the learning how to code and actually learning c#. What you talking about and showing looks great and fun but it's to much for my brain is right now. Your videos are cool and very informative but just to advanced or geared to seasoned coders. But nice videos, one day I'll fully understand all the things you explain in your vids.

    • @matthewjohnson3656
      @matthewjohnson3656 Před rokem +1

      I’ve been programming for ten years and I have never heard of a span before

    • @davestorm6718
      @davestorm6718 Před rokem

      @@matthewjohnson3656 Same here (25 years!) and just heard of a span a month ago (that isn't )!

  • @zagoskintoto
    @zagoskintoto Před rokem

    Great video! I'm curious, is Span still faster if there's heavy processing of the data done inside the loops? What if (as a separate question) you were to perform async operations like retrieving data from a DB inside your parallel loop, implemented with the Parallel.ForEachAsync method? How does it compare when just using Span?

    • @ImmoLandwerth
      @ImmoLandwerth Před rokem

      You can’t use await in a method that uses spans

  • @deus_nsf
    @deus_nsf Před 2 měsíci

    This is super interesting! I never learned about "spans" in any school, I don't even know what it is! I will eventually google it but could you elaborate quickly in case my laziness gets the better of me? 😅Thanks!

  • @RCYmacau
    @RCYmacau Před rokem +1

    Nice video.
    I am also interested if there are any actual difference between Span and an Array, which in my opinion should perform more like the same.

    • @nickchapsas
      @nickchapsas  Před rokem +4

      There is a difference indeed. I’ve covered this in the dedicated span video if I remember correctly

    • @user-pn1gt2km5r
      @user-pn1gt2km5r Před rokem

      @@nickchapsas there will be no performance difference iterating Array vs Span, and why would there be - both represent contiguous memory with minimum overhead. List is a different story because it has some additional logic, and you are paying the (small) price for it.

    • @renauddanniau676
      @renauddanniau676 Před rokem

      @@user-pn1gt2km5r Actually there is. I also have noticed that

  • @CricketThomas
    @CricketThomas Před rokem

    The puts so much perspective on things 😅

  • @micmacha
    @micmacha Před rokem

    Thank you, I literally didn't even know about spans.

  • @AbhinavKulshreshtha
    @AbhinavKulshreshtha Před rokem +3

    80085, I see a man of refined culture. 😅☺️

    • @krccmsitp2884
      @krccmsitp2884 Před rokem +1

      The zip code of the Simpsons' home town Springfield.

    • @AbhinavKulshreshtha
      @AbhinavKulshreshtha Před rokem +1

      @@krccmsitp2884 I didn't knew that.. I was thinking about the old calculator trick we used to do in schools during mid 90s, when we first got to use them.

    • @krccmsitp2884
      @krccmsitp2884 Před rokem

      @@AbhinavKulshreshtha Well, that's the other meaning. I know that trick too and what you wanted to indicate. :-)

  • @gergelycsaba5008
    @gergelycsaba5008 Před rokem +1

    1:35 Nice seed value :)

  • @elpe21
    @elpe21 Před rokem

    foreach statement cannot operate on enumerators of type 'Span.Enumerator' in async or iterator methods because 'Span.Enumerator' is a ref struct. Has that changed in .Net 7?

  • @swordblaster2596
    @swordblaster2596 Před rokem

    I doubt I'll ever use it, but quite amazing.

  • @Faygris
    @Faygris Před rokem

    Your channel is a pot of gold for me as a bad C# developer ⭐

  • @ceosmangumus
    @ceosmangumus Před rokem +1

    Foreach also has the same limitation, can't add or remove from the list, then we can replace each "foreach" with span version?

  • @nickst0ne
    @nickst0ne Před rokem

    When a program's performance tests are below client's expectations, would you always go for a Span refactorization?
    ...assuming that no major blunder was made like a bad algorithmic complexity.

  • @billy65bob
    @billy65bob Před rokem +2

    I'm pretty surprised, so they optimised out the allocation of the foreach enumerator?
    And somehow also eliminated the overhead of its constant 'version' checks (to stop changes mid iteration)?
    I wonder if this is a consequence of that 'sealed' keyword you mentioned the other day, or if other work also went into it

  • @user-qf2xk1fg6e
    @user-qf2xk1fg6e Před rokem

    Hello! At my job, we had an ague with colleagues what is better if you need to represent a collection in your DTO: List or Array. I think array is better. I had my own bunch of arguments about this, but would love to listen to your opinion about this question. Is there any chance you will make a video with close topic?

    • @Isr5d
      @Isr5d Před 7 měsíci

      depends on the usage. For DTOs (since there is no mutations) I prefer to use IEnumerable (most of the time) because it's implemented on almost all collections (Arrays, Lists ..etc). This makes things much easier to work with, and to avoid adding more memory overheads. If you want to only read, then just iterate. If you want to mutate, then copy it to any desired collection type (ToList, ToArray, ToHashSet ..etc.).

  • @jeffreyblack666
    @jeffreyblack666 Před rokem

    I would say that with the error listed, it is only the 100 item list that is different for the For and ForEach.
    You can even see that when you run all of them options, you get the order the other way around for the 1 million item list.

  • @engineeranonymous
    @engineeranonymous Před rokem +2

    If you are algorithm is loop heavy, you can use loop unrolling for more speed.

  • @pauliusdotpro
    @pauliusdotpro Před rokem +10

    You cant update collection while doing regular foreach loop either. How come in this case it is not 'unsafe'? How the safety is different when compared to span?

    • @NEProductionE
      @NEProductionE Před rokem +1

      If you have a list items and you wanna foreach it with mutate just do foreach( var item in items.ToList()) and then you can mutate

    • @deamit6225
      @deamit6225 Před rokem

      But you shouldnt mutate a list while your iterate over it anyways

    • @stianramstad9683
      @stianramstad9683 Před rokem +3

      The span will not throw an exception that the collection is modified.
      Example:
      var list = Enumerable.Range(1, 5).ToList();
      foreach (var item in CollectionsMarshal.AsSpan(list))
      {
      if (item == 1)
      {
      list.RemoveAt(3);
      }
      Console.Write(item);
      }
      Will print 12355, without giving an exception.

    • @billy65bob
      @billy65bob Před rokem +2

      It also depends how you modify the list in question.
      If you replace items in the list, it's not a big deal; you'll see the changes, and nothing will explode.
      CollectionMarshal even gives you a ReadWrite span, this is an expected and intended use case.
      If you remove things, you'll get odd and inconsistent results like Stian has demonstrated; In his example you are reading data that is out of range of normal indexers.
      This data is garbage; it's either stale, or null (depends on whether references are involved) and the span will not be aware of the new range.
      Now if you do add or insert, you'll be fine until the backing store has to expand.
      You'll see the inserted data (up to the original size) until that expansion, but once that expansion happens I have no idea what the results will be.
      It depends on whether Span keeps the original backing store alive, and that I'm not sure of...
      if it does, you'll stop seeing changes in your span, if it doesn't, then it'll either explode in your face, or expose you to C style bugs where you end up reading memory you're not supposed to; the latter is very bad since it leads to issues like OpenSSL's heartbleed.
      The short of it is: if you do ANYTHING that can affect the size of the backing store, you are playing with fire.
      While you'd normally use an array with Array.Fill for this, this example is completely above board.
      public static void ResetCounters(List counters)
      {
      var span = CollectionsMarshal.AsSpan(counters);
      foreach (ref var counter in span)
      counter = 0;
      }

  • @irjgametube2995
    @irjgametube2995 Před rokem

    INSANE!

  • @somebodystealsmyname
    @somebodystealsmyname Před rokem +1

    I see what you did with the Seed :D

  • @markharby180
    @markharby180 Před rokem

    Nice one, could help increase complex reporting.

  • @carstenberggreen7509
    @carstenberggreen7509 Před rokem

    Tak!

  • @ItsTheMojo
    @ItsTheMojo Před rokem +2

    The only approach that doesn't throw an exception if the collection changes, at least as far as I know, is a for loop. Anything that uses an iterator will throw because the MoveNext method checks the version. So that covers foreach and the List.ForEach methods at least. The parallel ones almost certainly won't handle a collection change during iteration. Most of the time,
    changing a collection while iterating over it in any way is undesirable.

  • @hamedsalameh8155
    @hamedsalameh8155 Před rokem +1

    This is really amazing Nick! Even in the things that seem so basic in simple, we are finding hidden gems!

  • @MarkusSchaber
    @MarkusSchaber Před rokem

    It's nice that you check the IL code, but what about the JIT?

  • @nove1398
    @nove1398 Před rokem

    Very interesting stats here

  • @clark435
    @clark435 Před rokem

    Eyy new video again

  • @harag9
    @harag9 Před rokem

    Wow impressive results, depending on what work you need to do within the loop, a Parallel span loop might be good.

    • @jongeduard
      @jongeduard Před rokem +1

      See my other reply, it's not possible without unsafe pointer tricks, due to the fact that a Span cannot escape to the heap. It simply won't compile.
      Parallel loops make use of callbacks (delegate, lambda, which is basically a reference type object) and therefore need an allocation in the managed heap.

    • @harag9
      @harag9 Před rokem

      @@jongeduard Ahh thanks. I've never used a span - still use 4.8 :(

    • @jongeduard
      @jongeduard Před rokem +2

      @@harag9 Someone else replied to my other command that it is actually possible. :P
      Something with Partitioner.Create and a Tuple. I would still need to dive into that one and try it myself to better understand it.
      Let's conclude that a simple solution does at least not exist.

  • @TheMAZZTer
    @TheMAZZTer Před rokem +5

    You can't mutate the collection in any foreach anyway so there's no downside to using the span method it would seem to me. So if you need to mutate the list you're using for instead of foreach anyway and just can't use the span.
    Very cool!

    • @jasonx7803
      @jasonx7803 Před rokem +1

      If you're running parallel code something else might be mutating the collection.

    • @lnagy88
      @lnagy88 Před rokem +1

      @@jasonx7803 Then maybe you shouldn't use a list and try something more thread safe.

    • @PelFox
      @PelFox Před rokem

      It's limited to List though, wished it would have worked for IEnumerable or IReadOnlyCollection. Very rarely do I need to iterate a List without doing some work on the data, then I would use a IReadOnlyCollection or IEnumerable.

    • @jasonx7803
      @jasonx7803 Před rokem

      @@lnagy88 I'm just responding to the idea that "there's no downside". Using a forEach isn't thread safe just because it can't modify the data, you still have to make sure nothing else is modifying it.

  • @vredurs
    @vredurs Před rokem +1

    I have a question regarding the iteration with span. Is it ok to modify the objects in the array as long as I don’t add or remove? Eg changing or updating a property? Thanks in advance

  • @syriuszb8611
    @syriuszb8611 Před rokem

    At the beginning I literally thought "I have no idea what it will be, but for sure it will use span!".

  • @B08AH
    @B08AH Před 8 měsíci

    I wonder, can you mutate the list when other iteration methods are used? No side effects expected?