Junior Code Review: Laravel Routes, Middleware, Validation and more

Sdílet
Vložit
  • čas přidán 25. 07. 2024
  • As a part of my new Laravel mentorship program in my home country Lithuania, I started doing code reviews of my student developers. Here's a 20-minute example that I decided to publish on CZcams - should be useful to you guys, too.
    00:00 Intro
    01:33 Route Grouping
    04:08 Shorter Middleware Class
    07:01 Middleware with Parameters
    09:06 Migrations with Foreign Keys
    10:32 Controller Index Refactor
    14:03 Code Styling
    14:46 Store and Validation
    18:00 Update and Route Model Binding
    Related resources:
    - Route grouping: laravel.com/docs/8.x/routing#...
    - Middleware with Parameters: laravel.com/docs/8.x/middlewa...
    - Migration foreign keys: laravel.com/docs/8.x/migratio...
    - PHP Ternary operator: www.codementor.io/@sayantinid...
    - Eloquent "When" method: laraveldaily.com/less-know-wa...
    - Code Styling and PSR-12: blog.quickadminpanel.com/psr-...
    - Laravel Validation with Form Requests: laravel.com/docs/8.x/validati...
    - Route Model Binding: laravel.com/docs/8.x/routing#...
    - - - - -
    Support the channel by checking out my products:
    - My Laravel courses: laraveldaily.com/courses?mtm_...
    - Laravel QuickAdminPanel: quickadminpanel.com
    - Livewire Kit Components: livewirekit.com
    - - - - -
    Other places to follow:
    - My weekly Laravel newsletter: us11.campaign-archive.com/hom...
    - My personal Twitter: / povilaskorop
  • Jak na to + styl

Komentáře • 419

  • @mathiasdesouza
    @mathiasdesouza Před 3 lety +400

    "Juniors don't be afraid to show your code. Seniors don't attack the juniors that the code is bad. We all start somewhere."

    • @JimOHalloran
      @JimOHalloran Před 3 lety +63

      So much this... I've been doing Software Dev for 26 years, PHP for 16 years, and Laravel for the last 2.5, and I learned something from this video. So I'd also add "Seniors, don't assume you know everything, and your way is the only way."

    • @Towzlie
      @Towzlie Před 2 lety +4

      @@JimOHalloran Every day there is new oppurtunities to learn things, we shoudn't feel ashamed to do so !

    • @ryanbeatbox
      @ryanbeatbox Před 2 lety +3

      Absolutely, thankfully my team lead adopts this mentality as well. Such a good quality to have in leadership and development in general.

  • @DuilioPalacios
    @DuilioPalacios Před 3 lety +307

    The delete action using "GET" instead of "DELETE" might expose the user to CSRF attacks. That one should be changed for security. (I hope this observation can be useful for someone).

    • @themostnonchalant
      @themostnonchalant Před 3 lety +1

      buen dato , maestro.

    • @digitalminister5687
      @digitalminister5687 Před 3 lety +5

      3:54 he mentioned it

    • @duiliopalacios1777
      @duiliopalacios1777 Před 3 lety +7

      ​@@digitalminister5687 Yes, I know, I just wanted to point out the potential security issue, that's all :) I also record videos and it's challenging if not impossible to cover everything in one video no matter the length.

    • @JohnSmith-zl8rz
      @JohnSmith-zl8rz Před 3 lety

      styde needs updated videos on laravel 8 ;)

    • @DuilioPalacios
      @DuilioPalacios Před 3 lety

      John Smith what does that have to do with this video? And FYI I do have tons of videos in L8, just not in my CZcams channel.

  • @EsronDtamar
    @EsronDtamar Před 3 lety +55

    I liked the video format. And today I noticed that I'm not a junior anymore.

  • @gyohza
    @gyohza Před 3 lety +45

    Omfg. This is like those "very satisfactory" videos with people slicing colored clay, but with coding.
    Such a rewarding feeling to watch.

  • @ShekenZZZ
    @ShekenZZZ Před 2 lety +15

    Yes ! Please ! More code reviews videos ! As a junior I can't state how valuable this is. Thanks for everything !

  • @richardtaylor8790
    @richardtaylor8790 Před 3 lety +2

    Love code reviews like this! Please do more. It's a great way to learn. Thanks!

  • @junaidahmad5783
    @junaidahmad5783 Před 3 lety +8

    Amazing concept! Please do as many videos as you can easily. This is great content. Keep up the awesome work. 👍👍👍

  • @zomgpro
    @zomgpro Před 3 lety +2

    Great video, love the format. Never knew about the eloquent "when" method. Good way to plug gaps in your knowledge

  • @randomguy5922
    @randomguy5922 Před 3 lety +2

    Very nice sir, most of the tutorials on net only deals with beginners things, ie how to start or more advance things, but you literally deal with minor problems which developers actually face, while developing something. I highly respect you for your efforts.

  • @tlita93
    @tlita93 Před 3 lety +5

    Such a phenomenal idea for the video. This what I was looking for back when I started just a year ago. I always had a feeling that new/beginner developers want to see what a real application looks like, how every part of it looks like, not just some examples and basic principles. Or even see other beginners how they code and it all looks like. So interesting. I will admitted, I do have some mistakes in common with the "author" of the code you reviewed. You should keep doing videos like this, it's really useful in terms of improving and seeing that we all actually make common mistakes, I'm no different than many other guys who started. It's a normal learning process and we shouldn't be ashamed of our silly, but important mistakes.
    Really grate video sir. 🙂
    Cheers

  • @tarangpanchal4424
    @tarangpanchal4424 Před 3 lety +26

    This means a lot of helpful to jr. developers to learn.
    I have seen many videos. many of video creators Assumes that you were aware about the mistakes that users do. but actually the fresher or junior developer wasn't aware of that. *And this is really fantastic video to identify mistakes and correct them*.

  • @noahbar-shain4218
    @noahbar-shain4218 Před 3 lety

    Extremely helpful!! I started coding in Laravel a few months ago, and while I know how to get things done, this helped me learn how to do them the right way.
    Thank you!

  • @KJARYA
    @KJARYA Před 3 lety +2

    Please make this into a more regular series, very helpful! Thank you.

  • @chaosthelegend6338
    @chaosthelegend6338 Před 3 lety +2

    I've never written a line in PHP but still watched till the end, you never know when you gonna need this.
    Great review, very satisfactory.

  • @camilorojas3261
    @camilorojas3261 Před rokem +3

    Eres grande amigo. No porque sepas mucho, sino por darte el tiempo de ayudar a los que saben menos. Saludos desde Chile.

  • @chrismellor7027
    @chrismellor7027 Před 3 lety +8

    Cool video concept. Definitely do more of these as they’re interesting. I learnt a few things too 🥳

  • @SunilKumawatbfcj
    @SunilKumawatbfcj Před 3 lety +5

    Hello sir
    You are the most humble and kind person in the region. You always appreciate others for working hard instead of dominating them for mistakes, and helping them grow each time. I think your contribution to this growth of laravel is remarkable.
    Help is only help, whatever form it may be given, and I am grateful for your efforts and love.

  • @sharjeeljan
    @sharjeeljan Před 3 lety +1

    Loved your disclaimers!! Great video! Thanks for sharing. I'm also a junior developer and learning a lot from your videos.

  • @nagaindra2323
    @nagaindra2323 Před 3 lety +1

    I have completed my last project fully with query builder only. This video help me to under stand the standard of code. Thank you so much sir. You videos help me lot

  • @redward4383
    @redward4383 Před 3 lety +3

    Awesome video, happy to see that I'm doing at least some of the things right, but even happier to see what is expected from me to write a better code in laravel.

  • @guilhermemoraes4055
    @guilhermemoraes4055 Před 3 lety

    Please make more videos like this!
    I loved to check what I am doing wrong and how to fix it and make it a better code !

  • @DasBeatz
    @DasBeatz Před 3 lety +1

    Thank you this was awesome! As someone just refreshing their Laravel knowledge I learned so much

  • @Ivoryke
    @Ivoryke Před 2 lety +2

    I really enjoyed and learned watching this one as a junior programmer!

  • @rikiamaru
    @rikiamaru Před 3 lety +3

    i agree with you on this statement
    "as junior dont be afraid to make mistake (but take responsibilty on that)"
    "as senior dont attack your junior (we have to start somewhere right)"
    huge respect to you!!

  • @altynbekmamasadykov4526
    @altynbekmamasadykov4526 Před 3 lety +1

    Thanks for your videos Povilas, I am also beginner laravel Developer, i'm your fan, your videos are very helpful. When I start earning money i will obviously buy your " eloquent course"

  • @justnothing7822
    @justnothing7822 Před 2 lety +1

    Your one video > Tones of Learn laravel from strach for Inermediates.Thank you Sir, have a better life everyday.

  • @11r3start11
    @11r3start11 Před 3 lety +4

    Im experienced web developer, but a c# one. Have no idea why this video appears in my recommendation, but it's ASWESOME.
    For me It was a good overview of PHP/Laravel development). Without any experience I understood 100% of it! Thanks.

  • @ollimac73
    @ollimac73 Před 3 lety

    Great video, need more of this unique learning, particularly useful for any dev level. Amazing advice to junior and senior at the video introduction. 👏

  • @vsaliyy
    @vsaliyy Před 3 lety +2

    really incredible video quality, learning from your lessons constantly. At work, I recommend your videos to colleagues. Thank you for such quality content!
    hello from Russia, city of Stavropol: 3

  • @yuriysemenikhin302
    @yuriysemenikhin302 Před 3 lety +5

    I haven't done Laravel in years, but it was still interesting to watch :-)

  •  Před 3 lety +1

    This video format is great for the channel as the comment/view ratio it gets. Some stuff is obvious but other is just awesome. Keep this series coming along.

  • @0xshashwat
    @0xshashwat Před 2 lety +6

    That $request->validated() and $fillable combination was on another level. Got to learn something new 😄

    • @0xshashwat
      @0xshashwat Před 2 lety +1

      @@mbparvezme Validation messages can be set in the Request Class created using " artisan make:request" command. Laravel will take care of the rest. And for the frontend you do everything same as before.
      Also check out the laravel documentation on "The Basic > Request" section it explains it beautifully. You can also use custom Rules inside the request class instead of if statements in the controller. 😉

    • @mbparvezme
      @mbparvezme Před 2 lety +1

      ​@@0xshashwat Thank you for your reply. It was my fault. I just forgot to include the "Accept: application/json" header in the request. That is why it send me a response with a redirect (back). But with the appropriate header, I got the error message.

  • @agungyudhaberliantara5561

    Best and crystal clear tutorial, thanks a lot 🙏

  • @SmailPeche
    @SmailPeche Před 3 lety +4

    after watching this video i’am not a junior developer anymore 😁 , more videos like this sir. this is awesome, thank you povilas ❤️

  • @debjit21
    @debjit21 Před 3 lety +1

    We need more this type of videos. Thank you.

  • @ChupachuGames
    @ChupachuGames Před 3 lety +11

    Another note: if you're looking to refactor your routes, please take the time to make some quick feature tests that hit your routes so you can test when you change anything if something breaks and follow the errors to refactor it correctly.

  • @nftsparatodos1274
    @nftsparatodos1274 Před 3 lety +1

    Nice video and so many tricks and advises in just 20 minutes. Thanks

  • @gdog6036
    @gdog6036 Před 3 lety +6

    The command in PHPStorm to highlight the next occurrence of a word is Ctrl+G on Mac and Alt-J on windows. On vscode it’s ctrl+D. Rather than moving the mouse and highlighting line by line
    Great content!

  • @nawt12
    @nawt12 Před 3 lety

    Hope this series got more video. very helpful for all. thanks a lot.

  • @chiagozieokafor5512
    @chiagozieokafor5512 Před rokem +1

    Thanks alot Sir
    This video is just so golden for me
    Will sure watch more of this kind of your videos 🔥🔥🔥

  • @gaelduval8410
    @gaelduval8410 Před 3 lety +3

    This chanel is gold... Great video, as always 🔥
    For this code review, I would also go for constants, instead of hardcoding Roles ID everywhere. Like ROLE_MEISTER = 0, and so on. Should make the code way more readable.

  • @stevendiaz7374
    @stevendiaz7374 Před 3 lety

    Nice video, very helpful for junior laravel devs
    Details that can simplify your life a lot!

  • @zuhrulanam5971
    @zuhrulanam5971 Před 2 lety

    Very cool how you give tutorial, thanks for the video man!

  • @frnkquito
    @frnkquito Před 3 lety +1

    Awesome video, perfectly explained, easy to understand, high value tips

  • @sadiarahman467
    @sadiarahman467 Před 3 lety

    Thanks a lot . Please , make more video like this. It's very educative.

  • @celebritydev1
    @celebritydev1 Před 3 lety +1

    Wish I could like this video 10x. What a great tutorial

  • @codingdunia
    @codingdunia Před 3 lety

    Keep it up sir. I always wait for your videos. I learnt more things in laravel.

  • @ajzack983
    @ajzack983 Před 10 měsíci

    I love these , I hope you still make them

    • @LaravelDaily
      @LaravelDaily  Před 10 měsíci

      I've made a lot of them, until I started repeating myself. See the Playlists of the channel, there should be one with reviews

  • @dumdcode3845
    @dumdcode3845 Před 10 měsíci

    This tutorial is very helpful!
    Thank you so much!

  • @resin01
    @resin01 Před 3 lety +4

    Great video. As for multi-line edit. Just double tap ctrl, and use arrow down to select all lines. Hit "End" to get the cursor to the same location on each line. Now remove the middleware in one go.

  • @ghostinplainsight4803
    @ghostinplainsight4803 Před 3 lety

    Refactoring is like ointment for my soul. I don't even use php but this is such a great idea for youtube content.

  • @georgebalan8452
    @georgebalan8452 Před 3 lety

    This was really great, had to pause a lot to think... :). Really useful to see.

  • @cxian
    @cxian Před 2 lety +1

    yes please do more refactoring session. Thank you!

  • @rajaasyraf25
    @rajaasyraf25 Před 3 lety +1

    Thank you for the video. We need more like this. Keep it up!

  • @rohannnsingh84
    @rohannnsingh84 Před 3 lety

    very very helpful sir you help me very much in laravel as i am also a laravel developer . Really thanks for your knowledgeful videos and keep ahead sir
    one more time thank you very much

  • @QueeeeenZ
    @QueeeeenZ Před 3 lety +12

    Can you please make more refactoring videos like this? please!! It was soo good!

  • @ricko13
    @ricko13 Před 3 lety

    Bravo! what a great video, I've learned a lot, thank you Sir, keep it going.

  • @coolcha
    @coolcha Před 3 lety

    Please create more videos like this. This is so helpful.

  • @klerfe85
    @klerfe85 Před 3 lety +1

    Awesome! Really really great idea for video. Practical examples...

  • @codeology1
    @codeology1 Před 3 lety +17

    Thanks , boss these kind of videos have great tricks... we need more and more

  • @udaranayana8305
    @udaranayana8305 Před 3 lety +2

    after 7 months of coding in laravel I finally got a hang of its basics... but this video shows me I just scraped the tip of the iceberg...

  • @muhammadhashiranwaar3239
    @muhammadhashiranwaar3239 Před 2 lety +1

    i just watched till 1:13 and i start loving you.... This is how juniors shud be treated... Love You Sir.

  • @rtpHarry
    @rtpHarry Před 3 lety

    Wow, I don't even code in Laravel but I couldn't stop watching. I wish there was something like this for code in Ionic, Angular, Vue or Firebase.

  • @rehabragab5937
    @rehabragab5937 Před 3 lety +1

    Great video,we need more videos like this

  • @azabudskyi
    @azabudskyi Před 3 lety +1

    Thanks. It was very helpful. A lot of tips that I think about every time when write code like "How to do in this situation" or "How it should be in correct way"?

  • @jimmyvasquez7980
    @jimmyvasquez7980 Před 3 lety

    What a video! Thanks! It 'was so useful!

  • @ahmedbreeka4379
    @ahmedbreeka4379 Před 3 lety

    wow , it's amazing , thank you very much , I got a lot of information in this video

  • @apriljoyaltiche3298
    @apriljoyaltiche3298 Před 3 lety +1

    More of this, please! I am just starting in the laravel world :D

  • @RindiBudiaramdhan040490
    @RindiBudiaramdhan040490 Před 3 lety +1

    need more like this. Code Review. Thanks for this share

  • @evanceomondi
    @evanceomondi Před 3 lety

    Thanks for the wonderful video.what I have been looking for.

  • @collincod4811
    @collincod4811 Před 3 lety +1

    Great Video. I would love to watch more videos like this.

  • @VadimBesedin
    @VadimBesedin Před 3 lety +1

    In PHP Storm you can use "Alt+J" to select next occurrences of the selected code or use "CTRL+Shift+Alt+J" to select ALL occurrences of the selected code.

  • @weybansky
    @weybansky Před 3 lety

    Thanks for this. Please do more of this 💕

  • @mibrahim4245
    @mibrahim4245 Před 2 lety

    simply, LEGEND !
    Thanks, I learned a lot ...

  • @ehabtalaat7592
    @ehabtalaat7592 Před 3 lety +1

    we need more videos like this .thank you for this video

  • @matinlh644
    @matinlh644 Před 2 lety

    Great senior tips, thanks alot 👍🏻

  • @user-dk5ek9nt2m
    @user-dk5ek9nt2m Před měsícem

    I am new to Laravel and some of these things are how I coding with Laravel, some are new and I'm excited to get more.

  • @kaelandchatman4780
    @kaelandchatman4780 Před 2 lety

    This was really helpful! Thank you :D

  • @rahafmoute4781
    @rahafmoute4781 Před 5 měsíci

    big thanks for you , you are the best in youtube truly

  • @vicsystems
    @vicsystems Před 3 lety +1

    You really boost the morale for LARAVEL for all junior devs.

  • @username8586
    @username8586 Před 2 lety

    You helped me alot with the $requests... I did it the same way as you mentioned but i left it inside the function what felt tottaly wrong and now i know why i had this feeling all the time

  • @JouvaMoufette
    @JouvaMoufette Před 3 lety +4

    Pretty good review. Only thing I would have said more explicitly is that Material:all() returns a collection, so the where is using PHP code to do its job. It may not be as obvious to the junior that the all() sets up the query AND fetches, where as the where function of the Eloquent model is simply utilizing a query builder and get does the fetch.
    The confusion mostly stemming from the collision of some function names in collections vs query builder for eloquent.

  • @madrise007
    @madrise007 Před 2 lety

    Great video Sir, thankyou so much.

  • @Nemnes
    @Nemnes Před 3 lety

    useful, its always nice to watch videos like that one

  • @vitouvitou5269
    @vitouvitou5269 Před 3 lety +1

    Thank you teacher .. please do this more

  • @cethartest469
    @cethartest469 Před 3 lety +2

    thx povilas, really awesome, we want more and more videos like this videoo

  • @GergelyCsermely
    @GergelyCsermely Před 3 lety

    Thank You. Very good tips for beginners. I learn daily really :)

  • @mr_possible6197
    @mr_possible6197 Před rokem

    Awesome video! Want more like these please

  • @raulrozza
    @raulrozza Před 3 lety

    I don't even code on PHP but I enjoyed the video, mostly for the lessons on organization and cleaner code.

  • @kevinkarin5900
    @kevinkarin5900 Před 3 lety

    This video inspired me to learn more

  • @yashpatel7291
    @yashpatel7291 Před 3 lety +1

    You are doing nice work in this video. I like it

  • @eleazarfederio1718
    @eleazarfederio1718 Před 3 lety

    your youtube channel is very informative

  • @ah-rasel
    @ah-rasel Před 3 lety +1

    I was just checking about Today's video 5 minutes ago 😁. Now here it is. Thank you Povilas.

    • @LaravelDaily
      @LaravelDaily  Před 3 lety +2

      Yeah, this one took longer time to produce than I expected. Started with idea that "I'll just give a few tips in 5 minutes", and published this video 4 hours later :)

    • @bilawalshah7700
      @bilawalshah7700 Před 3 lety

      Laravel daily sir, it help us alot because we are junior

  • @nclsv
    @nclsv Před 2 lety +1

    Well then.. This 'refactoring' went so fast, I felt bad I couldn't follow everything. Time to brush up on my Laravel skills again.
    Quality video by the way. THIS is how juniors improve and learn different code styles and refactoring.

  • @SlimAndCherryTravel
    @SlimAndCherryTravel Před 3 lety

    This is really great, thank you. It's embarrassing to me that you probably just wrote more code in 20mins than I wrote all day today.

  • @jefferson-silva
    @jefferson-silva Před 3 lety

    Awesome video, thank you very much!

  • @artursponchiado7265
    @artursponchiado7265 Před 3 lety

    Excelent video! 👏🏻👏🏻👏🏻

  • @madesuande5255
    @madesuande5255 Před 2 lety +1

    It very help me as baginner aravel code. Thank you sir

  • @Tortuex_
    @Tortuex_ Před 2 lety +1

    Thank you so much ! so interesting to see ! :D

  • @thatsenam9183
    @thatsenam9183 Před 3 lety +2

    Awesome explanation.