Clean code challenge - Silicon Valley Season 5, Ep6 đ
VloĆŸit
- Äas pĆidĂĄn 1. 05. 2018
- đđđ Become ELON MUSK playing most HARDCORE iOS mobile GAME: saviorx.com ! đđđ
#saviorx #mobilegame #unity3d
Nothing puts the fear of God into a programmer like the inevitable code review. This is when a group of people analyze your code for errors and shortcuts and violations of standard operating procedure like using spaces instead of tabs. I once worked at a Wall Street joint where our code review was like American Idol auditions. We had a panel of reviewers made up of my boss, the COO, and the CFO. They were ruthless. I would have to fill out paperwork describing my feature/fix, project my code on the conference room screen, and execute it while explaining my workflow. The slightest violation sent me back to the drawing board while my team members snickered nervously. I still have nightmares about this particular panel. My soul review at the Pearly Gates will be less terrifying.
Thankfully, Dinesh and Gilfoyleâs code will be observed by a special prosecutor - I mean reviewer - because theyâre senior management, thereby saving them the embarrassment of a public flogging. However, Dinesh wants a public hearing, if only to prove that his code is superior to Gilfoyleâs. Jared is against this for a valid reason. âA little cocksmanship was okay when we were a small company,â he tells them, âbut the coders need to see you guys as equally competent leaders.â Dinesh canât handle not knowing if heâs superior, so he hounds Danny the Code Review Guy relentlessly until he reveals Dinesh was better! Danny asks Dinesh not to tell anyone. Of course, Dinesh tells the entire office. - KrĂĄtkĂ© a kreslenĂ© filmy
The second someone else enters into Dinesh and Gilfoye's relationship they unite. I love it.
I do wish the engineer from season one was there more often, she was the perfect balance.
With respect to Dinesh, Gilfoyle is so arrogant that I doubt he allows bugs live in his code.
What
But that's the thing about coding. When you write a very complex code, even small tiny things can cause bugs. That's why even companies like apple Facebook and Google who literally have billions of dollars still end up with bugs.
This comment makes no sense
Yea, that's not possible
@@MangoMotors I mean you are somewhat correct in the sense that bugs will occur, but they literally have hour-long debug sessions or just use something called checkpoint testing where all valuable data is relayed after a certain section of code to the console for analysis. If there is an error they know where it is and if there isn't the code is ready to be peer-reviewed again. Most "bugs" come from human logic error more so than syntactic.
Clean Code does not just mean having less Errors by the way
It means having fewer errors.
@@ettiennepieterse371 no it means writing a code using the latest frameworks and technologies with best coding practices in mind. A tight code without any unnecessary extra coding is a clean code
@@saqlainalvi5485 It doesn't have to be the latest frameworks but everything else you said is right.
@@amirnoble1371 Yes brother. But a programmer should atleast know the basics of every new framework that comes out for his/her favorite language. But yeah you are right it's not necessary.
Note: i forgot to mention. Clean code also involves managing complexity through oop.
@@saqlainalvi5485 what are you talking about? Not everything is object oriented
The real winner here is Jared (and Richard) who told them to layoff each other, because they're senior management now. He's proven right in the end when the engineers band together to make fun of 'senior management'.
You mean Donald
@@francisconicolau8528 not Donald, Other Jared. OJ for short
pfp đ
Nothing more devastating than Gilfoyle's monotone delivery of soul-crushing news đ€Ł
Dinesh's pull requests must be brutal
What does that mean
@@aheathcliff7227 A "pull request" is when you submit a change to the existing codebase. One or more of your colleagues will look at your changes and either approve them or ask for more changes before the code is "merged" into the main codebase. The more changes they ask for, and the harsher their comments are, the more "brutal" the pull request is.
@@ticallionz I never understood why code review comments would need to be harsh, it merely shows the insecurity and egotism of the reviewer, much more than the competency of the submitter.
Also there'd be so many new changes to review since I'd imagine Dinesh doesn't push his code in small chunks.
@@ccriztoff what the fuck is your problem
Dinesh is using spaces, Richard is going to be pissed.
pep80 biach
He is not
Tabs are for amatuers
ThunderAppeal ha!
ThunderAppeal tabs are for people who like to save time. I will admit it did screw me once.
This has nothing to do with âclean codeâ, clean code refers to a codebases readability, you can have clean code with a lot of bugs and ugly code with no bugs
Correct
I think theyâre just trying to make it easier to understand. âErrorâ is one word and easier to write into this scene than âcode with readabilityâ.
Yessirr
properly refactored and debugged code.
eh
as a programmer they must've been really good friends for them to meme each other like that in a professional workspace
They've been coworkers, housemates, and rivals from before this company was even a company. Then they both joined as founding members, and now they've got a team of 46 engineers reporting to them. So yeah, good friends is pretty accurate.
I love Dinesh and Gilfoyle. I've said it 1,000 times but the writing on this show complemented by their delivery is the most under rated. Of all time possibly.
Mike Judge is a fucking genius
every office has one Dinesh and Dany
Wait is that a racist joke or not
i wish i made enough money to relate to this joke
Fix a Fix yep its rly racist donât read it
But what every office needs is a Gilfoyle and a hairy Arab who can Chortle his balls
I had it when "Gabe" says , "Guys, Nononono, remember, we talked about this." Seemed like he was giving advice to Jim and Dwight lol đđ
-How's the code been going?
-T minus Dinesh.
@1:57 Gilfoyle slips a secret smile and coyly stows it away
Silicon Valley is my comfort show, I wish it was still on
Same :(
It finish at the right time... after 6 or 7 season shows start to decay
Just rewatch it
"I have to fire Danny" đđ
Do you know what dinesh says after that? I can't quite make it out over the music.
@@quinndirks5653 "I'll ask Richard" đ đ
Jyothir ganesh thought it was âafterwardsâ
OH, I thought he said "I have to fight Danny" haha
Danny was the human, who ate the tortoise and the hair after the race.
hare
No, he actually ate the hair
@@TooDamnFishy Tortoises don't have hair.
@ or...do they ?
Dun dun dunnnn
@@night00glider no they don't, they are not mammals
3:30 he should have made A Bug's Life joke
that would make his joke good
Dinesh: Less errors..
Stannis 'Gilfoyle' Baratheon : Fewer..
Gilfoyle plays magic lmao
Gilfoyle is a key here and in whole
Private review is stupid. Senior staff should be subject to the same standards as everyone else publicly
Better yet, hanging people out to dry when they make mistakes is counter productive. You don't get more productive by being shamed, you get more productive by being taught.
Wanooknox also weâre all humans we all make mistakes.
@@Wanooknox Yes. And this is actually used in top tech companies like Google, Facebook and etc...
In the end it doesn't matter, all code is committed to the same repository, and all commits are accessible by everyone who has access to the code.
Easy to see how made mistakes, how they got fixed, etc.
And ideally anyway, your branch would not get merged until every PR is reviewed and approved. And all PRs are public as well.
So this whole "private review" is basically useless and bullshit.
@@Wanooknox It is productive and you're not supposed to be shamed it's supposed to set an example so other devs won't encounter the same mistakes. While you can get tips from your fellow colleagues and not just the ones reviewing your codes.
These two guys are now marvel actors
"I see, fun at my expense" lol
That MisSteak line was actually pretty good though
âLaugh it up GILFâ. Hahaha
"did his code have less errors than mine?" - you can hear non-programmers wrote this script.
âNothing puts the fear of god into a programmer like the inevitable code reviewâ Jesus Christ well I guess thatâs one thing to look forward to when I get a job in coding
if you approche it right, you can grow a great deal from code and design reviews.
Reviews are actually the best way to learn and improve. Both reviewing and being reviewed
I actually like code review
... its really fucking easy just follow the rules. The best reviews are the ones where you learn a new way to look at things.
Its also not just about bugs, you learn to do things more efficiently from people who have years experience.
I relate at an uncomfortable level to Dinesh repeatedly practicing the delivery and phrasing of his joke at 3:23
Ohhh. The guy is literally like one of my old colleagues. So noisy in that high pitch voice. And taking credits for everything
My supervisor was that high-pitched guy at my old company. Guy made me want to cut my ears off every time he called my name
2:37 Lmao that coffee mug
" i m not gonna beg "
"PLEASE"
"PLEASE"
"PLEASE"
Lmao how jarad walks over and stops the loud gong
haha we're all laughing at you, gilfoyle - makes me laugh every time
Dude this show is my life.
Three way fight. The only way to coexist 'peacefully'
haha they actually put "made in china" song lol.
Never knew The Hound is a coder. What a cool guy.
4:42 That pentagram lol
I'm just impressed someone can find all the errors and bugs in a piece of course
MISTAKE HOUSE! haha
The Type O joke is low key đ€Ł funny
Danny, the hr lady,and John are the only 3 people who won against Gilfoyle(HR lady managed to actually annoy Gilfoyle by being right,to an extent).Dinesh never beat Gilfoyle but he was the only person who could keep up with him.
I donât really see how gilfoyle saw that as a âvictoryâ, he just predicted the obvious basically
Man, I would live in their world, as Russ Hanneman. Tres commas!!!
lol.
Higher Brothers đđŸđđŸđđŸđđŸ
Nobody:
Dinesh: I'm the fucking Tortoise!
Wonder what those who neither work in tech nor are familiar with it thin of this.
I must admit, while I used to be intimidated by PRs early on, now they either reinforce my good habits or address my bad ones. So they're win-wins all around.
And yes, especially with bigger PRs reviewed by more people, there's a nice sense of satisfaction when it's approved on the first pass. Like, BOOM! Nailed it!
I have so much sympathy for Dinesh, he tries so hard. đ
One of the best series I have ever watched
Same here đ€Ł
"Everyone is laughing" đ
I liked his jokes
Cute how Jared stills the gong
So danny got them both ??
Pretty much
âYou just have to swear not to tell everyoneâ
Dinesh: âI swearâ
Everyone, everyone... my code is better than......
2:59 "I hope the book you're reading is for work"
Book: "Coders at work"
@@user-dp5fq4vc8m thanks
I love how Gilfoyle can troll Dinesh into a scene
00:54 if you saw it give yourself a punch.
Love the outro
George eRRor Martin
I'm the f***in' tortoise.
gilfoyle watches GOT. uses FEWER from Baratheonđ€Ł
Actually Stannis used it because it's correct. Same reason Gil does.
@@BastardOfTheNorth Baratheon is Stannis' last nameđ if you watched the show, I dont have to clarify which Baratheon.
@@tarifadib I am aware of that.
HIGHER BROTHERS
Lovely office
These two are like a married couple with 20+ or so years of marriage behind them...they are comfortable enough to abuse, tease, make derogatory comments to each other and yet they are the best duo in tge series.
Damn. Gilfoyle is just a Rick from Rick and Morty. But a 32bit
*bugs lightgear*
i know itâs a hard time with all this covid shit but always..always Tabs over spaces.
oh hell no
@@KohenChia This is not meant for people that uses Microsoft Word as their IDE
Visual Studio Code with plugins for language syntax helper s installed changed my life.
Pycharm is also pretty good at that.
Going to the comments section is a must
"Gilf"
They are the definition of a married couple
Damn the Higher Brothers got a song used in silicon valley
i miss this show so much
This is new to me... Stories get moved to review and the sprint is done... Well I guess they have a different definition of Done đ
I hope I never have to work with a Danny.
Not sure if I'd quit or give that one dude swirlies every time he opened his goddamned mouth.
Dinesh my man... Type O is the type you go to when you need blood : (
Wait thats Gabe..what is Gabe dokng there..
Probably telling people to shut up about the sunđ
Nice video
He really is the cool cousin
I loved how this show always wrote Gilfoyle & Dinesh to have a in work feud as who is the better coder. Yet like the episode where they go to Double A warehouse & they see the calculation of Blaine's pre skecthes & they start SWATTING (code)aka insults like fuck Gina, let Blaine die etc.
I love this show
dinesh and gilfoye are like two sibling always fighting each other but the moment someone hurt one of them their blood gets thicker than water
So this is where Gabe after Sabre.
George eRRor Martin is a must to read book
Ixalan is a Magic: The Gathering expansion block
The Jackrabbit Always Wins
I can't wait to be working in this field. Got 3 class to go
You are up for a massive disappointment if you expect this kind of environment.
@@fofopads4450 what do you mean?
@@dougsam6341 how is it
Pied Piper, amazing
the best web series I have watched
the office looks more like coderHQ, Texas
How to love this show more???
They are both the best pair their is
MTG on his desktop.
I like the man in China song!
Ahahha I'm laughing at this video
George Error Martin đđđ
Consider the tortoise- Dinesh
Stannis Baratheon FTW.
Blame it on the RGB ! Hahaha
What if San Francisco people didn't saw this as a comedy series and actually think this is the way they should behave at work.