Pretty biased take If you go through the video I’ve covered all these points in detail. I’ve mentioned you shouldn’t use sync fns Ive mentioned you shouldn’t run this raw and should run it in an isloated env Making a review without going through the whole video seems pretty distasteful Covering points like Eslint, prettier, devDependencies sounds unnecessary to cover in a video that covers Vercel
i think he mentioned in starting that he wouldn't be going through whole video and watch crucial parts and that's where he miss all those points you mentioned otherwise seems a genuine review to me.
made my best effort to not make the video distasteful or attack of any sort. clarified it multiple times all along the way. sorry if you felt that way.
@@prestigiouscall Haa ye definitely khe skte hai, Iss video ke baad sachme FAANG youtubers ka level pta chalgya hai ki wo kitna basic padha rhe hai aur bass DSA aur MERN(basic) krte rhte hai...
@@Ayush37262Bhai Teri Puri personality hi companies ke around hai kya? khud khuch karne ke liye nahi ghusa tha kya tech me DSA bas ek criteria hai filter out karne ka logo ko aur uske upar se voh bas ek cs ka subject hai lol itna hype up kar rakha. problem tab aati hai jab bande sirf DSA karte hai aur baaki khuch nahi
I think harkirat mentioned everything beforehand if you see the video clearly, eg about the docker, the 5 sec delay and many other things, It was clearly not a production level project....
@@yowaimo890 speak for yourself... If you are smart tell others who not smart like you to stop watching his videos. Curious if you also watch his videos? I hope you're not like them.
This format is so unique. More of the Dev YT creators should do this code review format instead of already overflooding reaction stuff which is only good for entertainment ( i guess reaction vids get more response, that could be one reason .. creators get inclined towards it ). Even better could be if the original developer could join the review and share his thought process or clarification, then it wouldn't even leave a bad taste for the original dev who can otherwise consider this as a roast video.
Please can you explain how to replace the exec command with docker container. How would it be created, programmatically or through some shell script before running the code
accha bhaiya main abhi 12th me hu , science field to main ethical hacking pursue karu ya phir web dev , kyuki lagta hai hacking karna bahutt accha hoga kyuki jaise-jaise AI aa raha hai uss hisab se mughe future secure karna hai aur hacking me bahut kuch hai aur new-new technology me bugs kojna aur hack karte rahena se main up-to-date rahunga isliye please bata digeye
Things can be built fast but it comes at a lot of cost. In my previous company also they used to build things fast but they totally used to ignore other things
quality > quantity then? most of these creators are just selling shovels during a gold rush, it can be made of steel or even paper, people will flock to it
Good to see you're putting so much thought into the security of the app (since you're building a business of yours as well) and that's how it should be. Loved the breakdown!
bro your knowledge is soo good and i understood the blunders you mentioned. Keep making these types of project reviews and tell us about production details that we actually need.
This is the actual content youtube is missing, most of the people use FAANG names for only low level mass media projects but never provide that quality and focuses on architecture due to which people are never able to know the complexity behind actual web development. Got to know about you through this video, loved your codedamn and loved your video. Thanks a lot for this.
Liked this one, it's very good that our Indian tech community is improving very rapidly, that era was gone into dark where only beginner level videos are being pushed by tech educators. If you get some time then please also create videos or projects that will teach advance stuffs like how to design scalable systems right way. Also how to code efficiently. What resources to follow to increase code efficiency and be a best in particular domain. May be the views will be less but the value it will create will be very vast.
Atleast some comments should have been used to tell other people that it is not safe to use exec itself and more than not safe to use it with unsanitized user input. It's like asking to be hacked.
i like this content this help ppl actually helps learn relevant things not a toy thing that barely stands on its legs do more of such 2nd walkthrough of code
Like I love this senior dev stuff......You can literally get the entry level stuff everywhere but this level of content.....You can only learn from a senior dev who has years of indrustry experience . Loved it ❤❤
That's how a code review needs to be done, brutal yet informative. i'd love this trend where instead of just learning the same thing again again, we can actually learn from the creator's code how that could have been improved and also learn the another person's perspective.
I think he was uploading the project files one by one. Instead, he should zip all the files and then upload them, so that no files are missed. This is important because some projects might change their behaviour based on the existence of a file. If there were thousands of files, then there might be some IO exceptions.
The thing about forEach(async file => {}) line is that forEach does not accept async functions. So even if you give it async function, it runs it synchronously. Same with map, filter, etc. The only way to do async stuff in a loop is using a for loop in js
you missed the point of the video, harkirat's channel shifted to content creation the moment he launched his course. It's more like his second source of income rather than a hobby. He is just pushing unique video that is just not available elsewhere to take clout and imo its a good thing on a beginner level just to get started
we need more videos like this so we know that what tutorials are adding bad code just for sake of video, content maker should make proper production level code for learning as well so we know the right direction
Perfect review and it ultimately benefits the students who are building projects along with best practices because of these type review videos, loved it ❤️
very nice and informative as always. Boss is always a boss. You review code is goddamn. codedamn!! . it's always great to learn from you Man.! Cheers! just to add; can you throw some light on the arbitrary code execution avoiding through Docker. like how this thing will be created in similar code bases? this is something interesting to learn.
Also, I don't get the logic behind the sleep timer. I mean he did await each upload call anyway. Then why would he have another sleep statement. If the upload promise has resolved then that particular file was done and dusted why would you sleep again? And Promise.all kyun use karna hai if the await is already in place? I mean await ke baad toh promise already resolved hai. Right?
@@mehulmpt I thought you meant that within his code he should have added an Promise.all to encompass the forEach. I mean it's just that ki if you have added await to hold of the system for upload then Promise.all will be redundant (in his current code not otherwise) Also, what's with the sleep timer? Again he awaited the entire thing then why do I need this sleep? I though might be due to the queue Init or connect but doesn't seem so
27:15 s3 uploadFile function does not return a promise, thus you can't await. Mehul you raised this 'uploadFile await kiu nhi hai' point multiple times, although there are ways to make this promisified but s3.uploadFile can't be awaited.. Correct me someone if i got this wrong
Bro how did u know so much about this man! U made my knowledge look peanut. Please make detailed video on server , docker, security and deployment level stuffs.
polling the db table is not a great move. I mean if you have a read instance then maybe. cost benefit has to be seen, if a durable queue is cheaper than replication and maintaining the replication lag. The other way could be to use something like any SNS to trigger read from db.
less than 4 reads per second is nothing for a production heavy database like Postgres. You’re wrong when you say polling the db is not a great move. It absolutely makes sense for this architecture.
This is a great review, We as the Indain Community need to talk openly about the work & do these discussions instead of DSA roadmaps, Web dev roadmap videos everywhere. I would call this distasteful really feels bad that he felt that way but its human nature and its all good. A second objective set of eyes on something is always better, plus it starts up further discussion about these things even if harkirat had already mentioned them, now more people will watch both the videos. Please keep doing things like these. You can even review subcribers' projects that will be really fun! We need more videos on production level code.
This type is good coz we can learn many things but i would suggest pick a code base and show how to improve that code fro a senior point of understanding and i am pretty sure many developers will get benefit
I follow Harkirat a lot. Never thought he would do serious mistakes like the ones you pointed out. Can you name few resources for beginners to go through in order to build production quality projects.
Really impressed by you, i have seen lot of indian devs who are just focused on making the product but not with perfection or modern design patterns, but you do care about lot of things that should be cared for such as zod or validation, Overall the code is very bad its not at all production ready but again for 4 hours we can ignore those things
Can you make a video on what to tech to learn in 2024 (completely new to computers) Note:- the field must be high paying 🤑💰 potential..... Someone suggest me devops? What u think
I think it’s easy to criticise someone who is taking a way bigger step than any other indian tech youtuber. I don’t think any one is near Harkirat in terms of quality and complexity of projects he is putting for free on youtube. Hats off to him
@mehulmpt Hey Mehul first of all thank you for creating this kind of videos because we as a developers have default intent that it's coded by any senior than definitely it would be a thoughtfully written code but it's not always. It would be of great help if you could create this or any small projects which would teach what ideal backend code should be. Specifically I didn't understand the exec(npm build) things you explained I mean could you please also tell what should be the correct code.
Hello Mehul. I understand that you are a much more senior developer than him. Your review was great, really appreciated it. But if you are genuinely just trying to give suggestions and you know for a fact that harkirat could have done better if it wasn't a beginner friendly project, AVOID those weird laughs as it seems kind of disrespecting. Both of you are great though I have great respect for you guys. it just felt that way so thought of mentioning.
To differentiate yourself from 1000 other candidates its important that you build production level projects. While this is a good attempt to build something i hope people dont get carried away to build like this. As a baseline, whatever you build should atleast be able to handle 1000users. That should guide you to build better projects
Interesting video. But you could have waited a bit more and come up with a proper solution extending harkirat's codebase explaining things from a production point of view. That way the beginners after finishing harkirat's video would have referred to codedamn. For example, a simple refactor of the promise awaits, showing the integration of docker, presenting the potential risk of using `exec` and refactoring it.
Regarding the queue for Deployment Jobs, I guess Kafka type queue is better than PSQL table. Reason being the ease of using Kafka coupled with it's features. So if we have multiple Deployment workers each worker would be responsible for reading a row from table, acquiring lock on that entry (to ensure only 1 worker is working on a job), releasing the lock once done and in case of failure you need some sort of lock-invalidation mechanism with timeout maybe or something maybe better .... dunno. Anyway, I guess keeping upload separate as a service might be fine to act as a deployment manager and keeping deployers separate. Manager pe scale can be low and multiple deployment workers can be handled as and when needed. Let me know what you guys think
Everything you mentioned here (atomicity/locking/refreshing lock time) can be done in Postgres too in highly performant way. This is how playgrounds queue on codedamn also work
What we found working was trying to keep systems simple and avoid complication before it becomes necessary. We found Postgres is excellent for this and we don’t need very high volume read/writes or anything else that requires a dedicated queue. For this setup also I see no reason why complexity can’t be reduced by dropping a component in system design
@@mehulmpt Bro, totally agree and yes I mean you can get these locks and lock-cleanup, two phase commits and all ke sath but queue though can make things complex flexibility bhi tagdi deti hain. The idea being that over time as the system grows you *might* have complex flows, for example, upload triggers deploy, also a notification, maybe a cleanup post deployment, I mean like a generic event based system with multiple flow in that case events and queues coupled with good orchestration/choreo (depending on case) can help a lot. P.S I know in that case state machine with Postgres can work too. I guess depends on person to person and how much complex your system is that you want to go a particular way
@@mehulmpt and yes we can drop a service that's why I said if you want some sort of a manager that does more than just uploads then a separate service makes sense otherwise you are right, it's really of not much use
Bro how much exp you got like fore real i dont even get major of the topics like when you learned them in a job env or like by yourself will i be able to be like you or sir @@jayantchhillar4227
![Firebase mat use kara karo? [Code Editor Project Review]](/img/n.gif)
This is how a positive tech community looks like. Loving this ( Harkirat, Piyush and finally Mehul), keep it up.
channel name of piyush??
@@memories1778 Its 'Piyush Garg'.
All are professionally sound and mature, that's why all of them contributed here positively.
This is what it should be like.❤❤
What about the 🐐 Kunal
@@azammustufa665 kunal kushwaha 🤩🤩
Pretty biased take
If you go through the video I’ve covered all these points in detail.
I’ve mentioned you shouldn’t use sync fns
Ive mentioned you shouldn’t run this raw and should run it in an isloated env
Making a review without going through the whole video seems pretty distasteful
Covering points like Eslint, prettier, devDependencies sounds unnecessary to cover in a video that covers Vercel
Lol another e-lafda
Lagta hai jo nahi hona chahiye wo hone wala hai.
Na hi ho toh hi better hai
🙏
True
i think he mentioned in starting that he wouldn't be going through whole video and watch crucial parts and that's where he miss all those points you mentioned otherwise seems a genuine review to me.
made my best effort to not make the video distasteful or attack of any sort. clarified it multiple times all along the way. sorry if you felt that way.
This type of discussions should be the face of indian tech community rather than mugging DSA
Arey bhai, isme youtubers ki kya galti jab mostly companies puch hi DSA rhi hai 😂😂
@@Ayush37262 No issues bhai DSA fundamental h but my point was we shouldn't be known for that only
@@prestigiouscall Haa ye definitely khe skte hai, Iss video ke baad sachme FAANG youtubers ka level pta chalgya hai ki wo kitna basic padha rhe hai aur bass DSA aur MERN(basic) krte rhte hai...
@@Ayush37262Bhai Teri Puri personality hi companies ke around hai kya? khud khuch karne ke liye nahi ghusa tha kya tech me DSA bas ek criteria hai filter out karne ka logo ko aur uske upar se voh bas ek cs ka subject hai lol itna hype up kar rakha. problem tab aati hai jab bande sirf DSA karte hai aur baaki khuch nahi
@@user-vw2qt8vp8e Tu pagal hai kya kuch?? Dubara padhle comment ko, maine kab hype up kiya DSA ko...
harkirat's response : "Build codedamn in 2 hours 💀" just kidding
Lol it would be hilarious. Although the number features would be too many to fit in 2 hrs.
😝
I won't be too surprised if he says it
😂😂😂
Haha
I think harkirat mentioned everything beforehand if you see the video clearly, eg about the docker, the 5 sec delay and many other things, It was clearly not a production level project....
Then he shouldn't put a title like that on his video. Make sense?
No
@@tusharsnx
@@tusharsnx you dont know how youtube works now do you ? if someone actually believes what the tittle says then that person has to be you xD.
@@yowaimo890 speak for yourself... If you are smart tell others who not smart like you to stop watching his videos.
Curious if you also watch his videos? I hope you're not like them.
This format is so unique. More of the Dev YT creators should do this code review format instead of already overflooding reaction stuff which is only good for entertainment ( i guess reaction vids get more response, that could be one reason .. creators get inclined towards it ). Even better could be if the original developer could join the review and share his thought process or clarification, then it wouldn't even leave a bad taste for the original dev who can otherwise consider this as a roast video.
+1
Soo true!
would totally love to see it
you don't make production level code in 3-4 hrs 🤡
His knowledge is deeper than the Mariana trench 👀
No, more than challengers deep
who's knowledge, mehul or harkirat?
@@harinibapatla285 dude, tbh harkirat has written a mid code in this project. I dont know if he thought youtube doesnt deserve a more complex video
@@harinibapatla285 harkirat is hype
Yeah , I mean he is a Linux kernel maintainer. So his knowledge must be deep. 😅
Mehul bhai as person who is getting started with coding in js, is it okay to practise problems by seeing it, or first i should try it myself then ?
Please can you explain how to replace the exec command with docker container. How would it be created, programmatically or through some shell script before running the code
please do more of these breakdown videos I really learned a lot about security and practices that a good developers do. Thanks for this video
accha bhaiya main abhi 12th me hu , science field to main ethical hacking pursue karu ya phir web dev ,
kyuki lagta hai hacking karna bahutt accha hoga kyuki jaise-jaise AI aa raha hai uss hisab se mughe future secure karna hai aur hacking me bahut kuch hai aur new-new technology me bugs kojna aur hack karte rahena se main up-to-date rahunga isliye please bata digeye
Things can be built fast but it comes at a lot of cost. In my previous company also they used to build things fast but they totally used to ignore other things
quality > quantity then? most of these creators are just selling shovels during a gold rush, it can be made of steel or even paper, people will flock to it
Good to see you're putting so much thought into the security of the app (since you're building a business of yours as well) and that's how it should be. Loved the breakdown!
bro your knowledge is soo good and i understood the blunders you mentioned.
Keep making these types of project reviews and tell us about production details that we actually need.
This is the actual content youtube is missing, most of the people use FAANG names for only low level mass media projects but never provide that quality and focuses on architecture due to which people are never able to know the complexity behind actual web development. Got to know about you through this video, loved your codedamn and loved your video. Thanks a lot for this.
Liked this one, it's very good that our Indian tech community is improving very rapidly, that era was gone into dark where only beginner level videos are being pushed by tech educators. If you get some time then please also create videos or projects that will teach advance stuffs like how to design scalable systems right way. Also how to code efficiently. What resources to follow to increase code efficiency and be a best in particular domain. May be the views will be less but the value it will create will be very vast.
Atleast some comments should have been used to tell other people that it is not safe to use exec itself and more than not safe to use it with unsanitized user input. It's like asking to be hacked.
More videos like this , please this type of knowledge is highly appreciated 🙏
i like this content this help ppl actually helps learn relevant things not a toy thing that barely stands on its legs
do more of such 2nd walkthrough of code
Like I love this senior dev stuff......You can literally get the entry level stuff everywhere but this level of content.....You can only learn from a senior dev who has years of indrustry experience . Loved it ❤❤
bro why dont u try to make coding codedamn in 6-7hours?
Your code review was awsomeeee!!! it gave insight into the mind of a pro dev
Just wow. Loved your breakdown and everything.
That's how a code review needs to be done, brutal yet informative. i'd love this trend where instead of just learning the same thing again again, we can actually learn from the creator's code how that could have been improved and also learn the another person's perspective.
Honestly! you did a very good review.....Aj class me bolna padega kirat bhaiya ko readme add karne k liye.
Can you please explain in English the language issue you mentioned in Index.ts? Line number 27-31 ig and what's the resolution for the same?
I think he was uploading the project files one by one. Instead, he should zip all the files and then upload them, so that no files are missed. This is important because some projects might change their behaviour based on the existence of a file. If there were thousands of files, then there might be some IO exceptions.
Great code review 👍 (watched till 18 min mark as of now).
Can you please do the same for Piyush Garg's version of Vercel build as well?
Thanks.
Same request as above
+1
The thing about forEach(async file => {}) line is that forEach does not accept async functions. So even if you give it async function, it runs it synchronously. Same with map, filter, etc. The only way to do async stuff in a loop is using a for loop in js
Bhai ek advanced backend project chaiye aapse .Would love to learn from your experience .
Kya aap vercel clone bana sakte ho postres use krke . Dhanyabad . Make it beginner friendly. Thanks
Friendly code review should come more and more . Loving this form of content .
Piyush has made perfect vercel clone video
you missed the point of the video, harkirat's channel shifted to content creation the moment he launched his course. It's more like his second source of income rather than a hobby. He is just pushing unique video that is just not available elsewhere to take clout and imo its a good thing on a beginner level just to get started
Please make more such videos ,it was highly informative 👏
To be honest loving this kind of video and this helping us that how real dev write prod code so keep it up ... gr8 work
Hey what is your vsccode theme ?
transparent
we need more videos like this so we know that what tutorials are adding bad code just for sake of video, content maker should make proper production level code for learning as well so we know the right direction
Bro, amazing video.
Learned a lot from this review.
Please keep making such videos🎉🎉🎉
Is there any web security course on codedamn 😅😅 lemme tell you are so good at it
Mehul is that real dev we need who has actually written prod code at scale
ha to bol na usko 2hr main kare prod code 🤣
great content sir 🤝 we want more like this video where we can learn about security and also code improvement 🧡🧡🧡🧡
Perfect review and it ultimately benefits the students who are building projects along with best practices because of these type review videos, loved it ❤️
very nice and informative as always. Boss is always a boss. You review code is goddamn. codedamn!! . it's always great to learn from you Man.! Cheers!
just to add; can you throw some light on the arbitrary code execution avoiding through Docker. like how this thing will be created in similar code bases? this is something interesting to learn.
Also, I don't get the logic behind the sleep timer. I mean he did await each upload call anyway. Then why would he have another sleep statement. If the upload promise has resolved then that particular file was done and dusted why would you sleep again?
And Promise.all kyun use karna hai if the await is already in place? I mean await ke baad toh promise already resolved hai. Right?
because that await inside forEach is useless. You need an outer await Promise.all(elem.map(t => t.action())) which I mentioned somewhere in the video
@@mehulmpt I thought you meant that within his code he should have added an Promise.all to encompass the forEach. I mean it's just that ki if you have added await to hold of the system for upload then Promise.all will be redundant (in his current code not otherwise)
Also, what's with the sleep timer? Again he awaited the entire thing then why do I need this sleep? I though might be due to the queue Init or connect but doesn't seem so
@Mehul Mohan Kindly make such a long format project please
I thought something was fishy with this tutorial😆. But bro your knowledge is superb👌.
Sir aap banao the clone vercel ka
love this video! please make more of these if possible.
Plz make a video explaining codedamn architecture
Best code reviewer ❤ Please make more videos on how to review code
Mehul bhai, great video! Plz create more videos on code review if you get time. Thanks
Learned a lot, specially regarding `exec` command. 🏴☠
He’s by birth a genius ❤❤ Nice explained btw
no hate, but he mentioned everything about how that proj is not a production ready.
27:15 s3 uploadFile function does not return a promise, thus you can't await. Mehul you raised this 'uploadFile await kiu nhi hai' point multiple times, although there are ways to make this promisified but s3.uploadFile can't be awaited..
Correct me someone if i got this wrong
Bro how did u know so much about this man! U made my knowledge look peanut. Please make detailed video on server , docker, security and deployment level stuffs.
refreshing creator in the ocean of all didi bhaiya for loopers
Piyush garg fixed some of these issues in his video. Can you try to review that as well ? Thanks for doing this great review video ❤❤
polling the db table is not a great move. I mean if you have a read instance then maybe. cost benefit has to be seen, if a durable queue is cheaper than replication and maintaining the replication lag. The other way could be to use something like any SNS to trigger read from db.
less than 4 reads per second is nothing for a production heavy database like Postgres. You’re wrong when you say polling the db is not a great move. It absolutely makes sense for this architecture.
When mehul bhai uses
js DSA logic
instead of c++/Java DSA logic
Explanation awesome
Love the positive approach
This is a great review, We as the Indain Community need to talk openly about the work & do these discussions instead of DSA roadmaps, Web dev roadmap videos everywhere. I would call this distasteful really feels bad that he felt that way but its human nature and its all good. A second objective set of eyes on something is always better, plus it starts up further discussion about these things even if harkirat had already mentioned them, now more people will watch both the videos.
Please keep doing things like these. You can even review subcribers' projects that will be really fun! We need more videos on production level code.
Justtr loved this video ... The energy ❤
He has talked about the security issue related to exec and a lot of other things.
Mehul.. Next video must be Piyush garg’s vercel clone code review. Please
This type is good coz we can learn many things but i would suggest pick a code base and show how to improve that code fro a senior point of understanding and i am pretty sure many developers will get benefit
great vid, learned a lot. Thanks man
I follow Harkirat a lot. Never thought he would do serious mistakes like the ones you pointed out. Can you name few resources for beginners to go through in order to build production quality projects.
So much knowledge, nice review 👏
bhaiya backend developer roadmap in hindi please
Bhaiya Postgres ko detail main explain karo ek video main please 🤝
I have really struggled reading the captions in the entire video to the end. If only there was an English version.
Please make a web security course on codedamn created by you.
bhai aapki hindi code community mein bohot zaroorat thi
aur content daalo idhar
We want one video from you creating a clone of some major service
Really impressed by you, i have seen lot of indian devs who are just focused on making the product but not with perfection or modern design patterns, but you do care about lot of things that should be cared for such as zod or validation, Overall the code is very bad its not at all production ready but again for 4 hours we can ignore those things
Can you make a video on what to tech to learn in 2024 (completely new to computers)
Note:- the field must be high paying 🤑💰 potential.....
Someone suggest me devops? What u think
I think it’s easy to criticise someone who is taking a way bigger step than any other indian tech youtuber. I don’t think any one is near Harkirat in terms of quality and complexity of projects he is putting for free on youtube. Hats off to him
Absolute blind following. Check the works of code with harry, Piyush, and many more Indians.
Exactly@@mehulmpt
@@mehulmpt yeah i checked .....still not that great..
@@uday8501 Bhai i wonder why he wrote such a bad code... it was one of the worst code i have seen, super ugly patterns used
@@mehulmpt you called him a blind follower and then mentioning code with harry xD
@mehulmpt Hey Mehul first of all thank you for creating this kind of videos because we as a developers have default intent that it's coded by any senior than definitely it would be a thoughtfully written code but it's not always.
It would be of great help if you could create this or any small projects which would teach what ideal backend code should be.
Specifically I didn't understand the exec(npm build) things you explained I mean could you please also tell what should be the correct code.
I guess 5 secodns ka timeout isliye hain because foreach ke andar await wait nahi karta so it is just hack he might have used in the video, I guess.
Everyday youtube recommending one after other videos stretching this conversation ahead around vercel clone
Hello Mehul. I understand that you are a much more senior developer than him. Your review was great, really appreciated it. But if you are genuinely just trying to give suggestions and you know for a fact that harkirat could have done better if it wasn't a beginner friendly project, AVOID those weird laughs as it seems kind of disrespecting. Both of you are great though I have great respect for you guys. it just felt that way so thought of mentioning.
please start uploading fullstack projects from scratch we need more tutors like you
22:27 Man I didn't understand anything from this part can someone help?
Looking forward for you coding tutorial on vercel
I already watched Harkirat's video, He did mentioned most of these issue. Also agree he deliberately did some jugad in most of the parts.
To differentiate yourself from 1000 other candidates its important that you build production level projects.
While this is a good attempt to build something i hope people dont get carried away to build like this. As a baseline, whatever you build should atleast be able to handle 1000users. That should guide you to build better projects
This kind of content we need 😊.. but make sure don't create any controversy stuff like 😂
Woh toh sahi hai but kirat ka comment thoda ajeeb aya hai😢 indirectly controversy na ho jaye
Interesting video. But you could have waited a bit more and come up with a proper solution extending harkirat's codebase explaining things from a production point of view. That way the beginners after finishing harkirat's video would have referred to codedamn.
For example, a simple refactor of the promise awaits, showing the integration of docker, presenting the potential risk of using `exec` and refactoring it.
Regarding the queue for Deployment Jobs, I guess Kafka type queue is better than PSQL table. Reason being the ease of using Kafka coupled with it's features. So if we have multiple Deployment workers each worker would be responsible for reading a row from table, acquiring lock on that entry (to ensure only 1 worker is working on a job), releasing the lock once done and in case of failure you need some sort of lock-invalidation mechanism with timeout maybe or something maybe better .... dunno. Anyway, I guess keeping upload separate as a service might be fine to act as a deployment manager and keeping deployers separate. Manager pe scale can be low and multiple deployment workers can be handled as and when needed.
Let me know what you guys think
Everything you mentioned here (atomicity/locking/refreshing lock time) can be done in Postgres too in highly performant way. This is how playgrounds queue on codedamn also work
What we found working was trying to keep systems simple and avoid complication before it becomes necessary. We found Postgres is excellent for this and we don’t need very high volume read/writes or anything else that requires a dedicated queue. For this setup also I see no reason why complexity can’t be reduced by dropping a component in system design
@@mehulmpt Bro, totally agree and yes I mean you can get these locks and lock-cleanup, two phase commits and all ke sath but queue though can make things complex flexibility bhi tagdi deti hain. The idea being that over time as the system grows you *might* have complex flows, for example, upload triggers deploy, also a notification, maybe a cleanup post deployment, I mean like a generic event based system with multiple flow in that case events and queues coupled with good orchestration/choreo (depending on case) can help a lot.
P.S I know in that case state machine with Postgres can work too. I guess depends on person to person and how much complex your system is that you want to go a particular way
@@mehulmpt and yes we can drop a service that's why I said if you want some sort of a manager that does more than just uploads then a separate service makes sense otherwise you are right, it's really of not much use
Bro how much exp you got like fore real i dont even get major of the topics like when you learned them in a job env or like by yourself will i be able to be like you or sir @@jayantchhillar4227
Thank god you made this video young dev must know stuff deeply, since OWASP secure code practices is a things 😂😂.
Aapko vercel se paise mile hai kya
Make some complex application tutorials if you really want the community to grow
could you make this video in english
he is an absolute MASTER in webdev
liked this type of reviews :)
awesome, learned a lot.
Just wowwwwww....
Do some advanced content in codedamn