Refactoring real-world Laravel app. Who wrote THIS CODE?!

Sdílet
Vložit
  • čas přidán 5. 02. 2023
  • I live for the clickbait.
    In this video we'll focus on refactoring a Laravel application using the 80/20 rule. We'll just go through the files, see what we can do to improve the code slightly without stressing over the details.
    More me:
    saaslaravel.com
  • Věda a technologie

Komentáře • 24

  • @user-zh2oz9fe4m
    @user-zh2oz9fe4m Před rokem +1

    It's a very useful video! Looking forward to seeing more of these)

  • @limitlesskode
    @limitlesskode Před rokem +3

    The refactor when you delegated the user service instantiation to laravel was quite cool. I was manually creating these instantiations in the constructor body and I think I will refactor to your approach.

  • @natenatters
    @natenatters Před rokem +2

    I really like the refactoring videos! Nice job. Good to aim for the 80/20 rule too, you seem to get a lot of work done quickly!

    • @saaslaravel
      @saaslaravel  Před rokem

      Thank you Nathan! I'm learning Vim so maybe I'll be able to push that speed even further 😊

    • @natenatters
      @natenatters Před rokem +1

      @@saaslaravel Oh no 😆Im happy to watch you work in Vim, but I refuse to learn it as an IDE haha

    • @saaslaravel
      @saaslaravel  Před rokem +2

      @@natenatters It's def challenging but that's what makes it fun haha :D

  • @gotoslovakia
    @gotoslovakia Před rokem

    Great job. Thank you

  • @akhileshkumar-iu9uq
    @akhileshkumar-iu9uq Před 4 měsíci

    Can u name the vscode extension which make ur code very real

  • @karlson2804
    @karlson2804 Před rokem

    Very, very cool format, if possible, shoot more, please.

  • @mohammadashrafuddinferdous9347

    At 8:24, UserService isn't the appropriate service class. It should be user order service if there are any other type of order services. Otherwise, user service will be a god service, sooner or later.
    And i think usrr service should always return user objects. It can be user model or dto or the collection of dto or user models. But when it returns anything else, it breaks the law of diameter.

    • @saaslaravel
      @saaslaravel  Před rokem

      This project isn't super complicated and doesn't have loads of code, but if I was working on something more complex, I agree that UserOrderService is better

    • @mohammadashrafuddinferdous9347
      @mohammadashrafuddinferdous9347 Před rokem

      @Przemysław Przyłucki Surely, if it's not complicated and only one person is working on it, then the path is ok to me too.

    • @mohammadashrafuddinferdous9347
      @mohammadashrafuddinferdous9347 Před rokem

      @@saaslaravel I like you super simple dto btw.

  • @_bijaydas
    @_bijaydas Před rokem

    I see you have a few Enums. What is preferred storing statuses for products, users etc. in Enums or in a table? I used to use Enums but now converted all status to status table.

    • @saaslaravel
      @saaslaravel  Před 10 měsíci +3

      I use enums that cast to an int and just save the int in the db. This way I have nice type hinting in the app layer and can add more enums without having to alter db

    • @SilverPaladin
      @SilverPaladin Před 7 měsíci

      @@saaslaravel I saw your Enum approach in another video and I love it! I hate having to touch the db to add or change the enums! I guess we could also add a layer on top of that for different languages?

  • @GergelyCsermely
    @GergelyCsermely Před 11 měsíci

    Thanks

  • @binaryfire
    @binaryfire Před rokem +2

    Great video! What are your thoughts on actions vs services?

    • @saaslaravel
      @saaslaravel  Před rokem +3

      I use actions as well - mostly when there a piece of logic that needs to be reused between different parts of the system, or when a service method has to interact with a 3rd party

    • @2gbeh
      @2gbeh Před 2 měsíci

      When to use Actions and when to use Traits ?

  • @carvalho1990
    @carvalho1990 Před 10 měsíci

    Is there a repo for this code? Amazing! thanks!

    • @saaslaravel
      @saaslaravel  Před 10 měsíci

      Unfortunately not, that's a private project

  • @Nodsaibot
    @Nodsaibot Před rokem

    ANY php project that it requires use of the CLI means you are doing things WRONG, PHP was not created for this use environment