When You Ask the Intern to Review Your Code
Vložit
- čas přidán 10. 09. 2023
- what happens when you ask the intern for a code review....
it's been a while since i last made a skit, i hope you'll enjoy this one
if you're reading this, comment: weather magician
ig: / niicholas.t
discord: / discord
#intern #coding #softwareengineer
sub count: 146 404
Lurking Sloth by Alexander Nakarada (CreatorChords) | creatorchords.com
Music promoted by www.free-stock-music.com
Creative Commons / Attribution 4.0 International (CC BY 4.0)
creativecommons.org/licenses/... - Zábava
The real intern experience is spending a week working on a PR, sending it in with everything ironed out perfectly, having crafted the best PR of your entire life, then seeing it rot on the task list with a low priority number for months
And then never getting merged until it is inevitably closed!
Bro!!
I thought I was the only one.
I had fixed a major issue in production, gave the PR and it got merged after two months lol.
I had literally zero tasks for those months
The best python package of my life was never even reviewed
This gave me PTSD
Months? More like years! I have in all seriousness a couple of PR's from over a year(when I started) open. Lets see if they are gonna be reviewed next year...
Intern tension: "I'm new and am expected to know these things. I can't ask or they will think I don't have a clue what I'm doing. But I also don't feel like I know what I'm doing."
Senior tension: "This kid must be brilliant because they haven't asked questions. They must know the latest/greatest practices so I can't question that. I don't understand this and I'm expected to teach them..."
Both: LGTM
There are some words in that hudge fact
As a frontend dev who started just 6 months ago i need to say that this comment made me calm 😁 Thanks
Omg is this what I get to look forward to?
True! The best is when seniors just explain everything without me having to ask😂😂😭
switching variable colour to color has made it 20% efficient saving millions of dollars in cloud cost. keep up the great work !
Lmao chuckled so hard 😂😂😂
Actually, "colour" is 20% less efficient than "color",
but "color" is 16,67% more effective than "colour"
You can actually put 10% of the code in the filename. Huge space saver.
😂😂😂😂
That feeling of "He wants me to review *his* code?" is truly universal for software devs
Intern manager had me dying 💀
Actually worked with an intern who manually changed his job title on the internal portal to 'senior software engineer intern' as it was his 4th internship at the company - made me giggle.
Fun and brilliant! But maybe also a way to say that rather than having a fourth internship one should be hired or at least get a consultancy? Don't know about the specific situation so maybe you'll tell more, but fourth internship (and at the same company!) sounds out of this world to me
@@matteosposato9448 i had a friend who did 4 separate terms at a big fintech company and he worked on a different team each time
@@matteosposato9448probably still in school so they were waiting to hire him
@@matteosposato9448I've seen that for students that are going into Master's program
This has no business being this good!! Insane how much work put into this, truly appreciate you.
glad you enjoyed it
@@nicholastwhat is the name of that utility at the start of the video where you are managing all the tasks, looks cool?
@@adityasuryawanshi3263 "Trello" I'm assuming
The real intern experience is spending a week working on a PR, sending it out for review, then finding out the requirements were all wrong because the senior engineer that gave you direction was not on the same page as the other senior engineers.
That's an every software developer experience, including for seniors.
Has happened so many times to me...
Classic
Ohhhh my god. Sooo many Easter eggs in this video. This had to take so much time and also worth every second!
after starting my first internship i can finally relate to all the intern memes and confirm they are 100% accurate
congrats on internship!
so are you intern manager yet?
Not only did I review my mentor’s PR, I REJECTED it
0:43 you forgot the holy title of INTERN CEO
chief intern officer
That's a CIO... 😂 not CEO
Chief Executive Intern
I will definetely add the following point to my resume
"Increased corporate profits by 27% by enhancing user experience by shifting critical ui component to utilize warm shades"
paraphrase: I made a button red
Naaah you legit gotta do that 😂😂😂😂😂😂. The smarter it sounds the more impressed the HR's are. It's legit comedy sometimes
I'm a junior dev. My team recently had a new senior dev join. Senior dev clones a repo and starts making some changes and asks me, why doesn't their code work. I tell them to please push their code to another branch so I can review. One week later, sends me a zip file containing the whole project repo (doesn't know how to use Git Hub). First thing I see are a bunch of nested loops, 150 lines of if-else statements, a bunch of poorly named variables, and no comments. WTF. I'm dead.
That doesn't sound like a "senior" dev, but what do we juniors know lmao, maybe he was into something
Been there, that’s real life. Maybe not at FAANG, but in smaller companies or teams this can definitely happen. Promotions based on seniority, not skill level…
My advice: Stay away from those companies/teams. Work with skilled people and for companies that value skill.
@@Haise-sanhe probably was on to something he didn't become a senior engineer just like that.
right guys ?
At least he zipped it.
He could have sent a rider into your town to read the code out loud in the market square.
HOW HOW HOW HOW HOW DID THAT HAPPEN ?????
My last interview I straight up outperformed 90% of the candidates and that was still not good enough. WHAT THE FUCK ????
I recently got put on a new project at work and this is way too relatable / anxiety inducing! Well done, sir!
Good ol intern days they had me twiddle from thumbs for 4 weeks then gave me some random code story development with one sentence in rally describing what to do and then being busy for the whole week only to get the jr offshore developer to yell at me for what I was doing 😅. The managers would then not find any other work until it was two weeks until I was supposed to leave and act like they loved me.☠️
If CI passes, it's totally fine. I just started at a new company and haven't really learned some of the systems yet, so I just depend on compiler errors and tests to tell me if I'm breaking things. Just like an intern.
CI is the bare minimum. Most part of code review isn't even about things that broke. Also really depends on the quality of CI how reliable it is for detecting broken things.
@@andyschee942 Big vouch for the Scheester. Making sure that your code follows the proper standards (well documented with comments, proper usage of variables and functions, ensuring everything is clean etc.) is super integral to having great code. Bad code breaks, good code just works, great code works and can be understood and fixed easily in the future.
Congrats on the promotion to Double Super Intern: First Class!
😂😂😂😂😂"Talks in Intern" I can so relate
I am SO happy to have you posting again! Damn near pissed myself laughing
LGTM!
Glad you enjoyed it :)
As a 28 year old whos never had a job I can confirm this is an accurate depiction of being an intern at a tech startup
Bum
Gigachad
Keep it like that. Work sucks.
@@SkyArmysGenerallife's tough and unpredictable. Be humble.
This made my day, great content!
I just started my web development internship, and this is relatable af
I showed your video to the Senior Intern on our team and he confirmed that this is how it goes.
love it man! Keep dropping.
video editing attention to detail goes craaazy !!
Bro I relate to this so hard 😂
I wonder what the world of "structured" software engineering is like. I'm working in research and optimising/adapting ML algorithms but there's no code review, only results review, and no one else knows my code but me. I feel like I'm losing my mind with the freedom I'm allowed because I'll have 5 things I want to do but can only have time to do 1.
I work on legacy mainly, and it's a lot of "do exactly what was requested, and _only_ what was requested". Just today I got back from lunch to find several messages about how a PR of mine last week broke the release branch for everyone on another (parallel) team. This issue could be solved with a basic try-catch, but to be honest having looked through it further I don't know that we want to even make the change I was asked to make (and already implemented, albeit with a bug) due to subtle issues that are direct results of this plan.
You need someone to help you with prioritizing the tasks, taking stakeholder impact into account
@@traveller23eThis was nice to read. Sometimes I'm scared that I'm the only idiot that makes these kinda breaking changes.
Im working as an intern in an ML research project, mostly just reporting results from different papers. I feel like ive hit a ceiling mathematically and my major isnt focused on ML its actually cybersecurity. How do you suggest I get better?
@@rewrose2838 Nah mate, people have broken release three times since I wrote that a week ago. As long as someone catches it before there's a real problem, you're fine.
Great content, was watching your vids while prepping for the interviews and they were great at boosting my morale.
Now after getting a return offer this week, this video seems like a cherry on top.
IVE MISSED THESE VIDEOS
The only difference between this and “seniors” reviewing is that they nitpick even dumber things and constantly ask you what something does
Knowing when and how to ask questions is knowledge too
I don't mind nitpicking, it's all in how they conduct it. If they ask the right questions, like "Would it be better if we do XYZ? or "Are we able to do such and such on this line?" than they give you the opportunity to rebuttal or agree without them feeling like an ass, and you feeling like an idiot. Most good companies train on how to properly review PR's, and its a Senior priority to keep comments professional.
loved the video. keep dropping more 👍
MORE SKITS COMING
Welcome back man!!
The relatability in this😂
Got a senior in my team whom's process is probably similar because he only nitpicks on stuff while there's huge blatant bugs in plain sight
It's that and also everyone has a Senior who just rubberstamps everything for their best friend that is filled with breaking changes, yet everytime they review your PR they go through it character by character nitpicking every detail with comments.
Was waiting for your videos :)
ayeee he is back with the quality content
This was too good!!!🤣🤣🤣🤣
Love that red "Purchase" button. Such a subtle detail describing a dark pattern. But hey, if it makes money....😂
this was hilarious 😂
YOOO my favorite youtuber uploaded, day made😍
LFFGG
i love when speech is coming through my back left ear
waited so long for a new video lesgoooo!
LGTM, great work! If this was real I would cry at my desk.
Another banger 🔥🔥🔥
i literally just had to review an MR on a project i worked on in the spring that a swe outside my team was trying to contribute to. It was terrifying
"No description provided" smells like Sr.Engineer
This is amazing, keep pausing the screen for the fantastic jokes all around
>guys why is prod down it's literally 1 am
"should be fine" now that's what i call high test confidence
This video was my reason to subscribe
ella ellaaa ehhh ehhhh shoutout rihanna !
good work on this one bro
+ Points on the theta numerology function, that was intense.
I have never related to a video more in my life 😭
This video had me in [speaking in intern] 😂. Idk why but it felt hilarious 😂.
‘speaking in intern’ had me dying considering I’m still learning the language
Is there are some more channels content like these? I really enjoy them😁
im boutta get that senior intern position
"senior intern" holy shit im dying
My left ear enjoyed this video 12.5% more than the right.
great vid sir
thanks for scaring me when I actually want to go intern lol
"Migrate literally everything to typescript."
Shit, I had tears rolling on my cheeks from laughing. Nice one !
Weather magician
Senior intern got me🤣
Hey nick,
nice to see youre making videos again!
looking forward to seeing some more! p.s. you didnt show us part 2 of the date
"speaking in intern" lmao
Intern => senior intern => intern manager....wow! great progress in career.
As someone that has no idea the nuance and genius of this skit, I kept waiting for the extra L in getUmbrelllas to pop up as the punchline. I assume since it didn't get pointed out that there are many little errors all throughout all the code in this and that's part of a running-gag-mini-side-punchline
Engineering Manager: guys who deleted 95% of the code?
SENIOR INTERN LMAO
"how do i run this?" Been there before 😭😭😭
"Senior intern" looool never heard that one before
I am near my internship completion, relatable af
fwiw I wouldn't even look at a large pr like that 😂
usually they won't get looked at for a vvvv long time
Lesson of the day, test before commit? lol
spot on 🤣
WEATHER MAGICIAN
"speak in intern" part make me 😂
Same thing happened to me as a intern. You know what my senior co-worker did? Without any word he stood up from his chair, walked next to me, took my laptop and reviewed it in 2 seconds. Yeah, at that time it was my first experience with git, so I didn’t even remembered what happened 😂 Of course he was teaching me more later
My lead is the definition of lgtm 😂 sometimes I’ll console.log some lyrics in my commits to see if they go through and they always do
hahaha this was good!
My left ear really enjoyed this
hes baaaaaaaack !!!
this is me as a full-timer
I’m tryna get promoted to full timer
So good 😂
I DONT CODE 🔥🔥🔥 BUT THIS IS FIRE 🔥🔥🔥
ITS OK IM AN INTERN I DONT CODE EITHER
Congratulations! You've been promoted to CEI, Chief Executive Intern.
This video is approved! LGTM
What no BiG Time Rush at the end lol!!!
HES BACKKKK
what was that first application where you drag and dropped a task from one list to another?
Congrats you are promoted to Senior Intern
*Senior developer handles me his work and I get stuck*
Me as an intern: I am stuck here. Can you help me out?
Send dev: Just figure it out!
*Sirens in distance
*Hyperventilation
*Database crashes
*HR calls for an urgent meeting
From what I’ve gathered from coding videos it seems no one really knows what they’re doing and if that’s true that’s funny as hell
its an exaggeration. applications can get big with a lot of moving parts so sometimes even experience seniors are seeing a part of the code base for the first time. But for them they eventually figure it out. I was assigned a bug ticket and had to get a senior help and we debug together. He was also super confused but eventually when i pointed out the root of the problem ( i had more time to read that part of the code) , he saw it was his faulty code written 3 weeks ago😂
@@rkpinata373 depends where you work, i can point you to the team fortress 2 code, sometimes it's just a bunch people bashing their head against the wall until something ends up working by happenstance
The “No description provided” on the pr hit deep 😂
Meanwhile we just push 30 commits per day without description to main xD
I love my team.
Ana left DotA to be a dev
hey bro nice video, may i ask when u apply for waterloo cs, do u have a selection for cs, or you gotta apply for math first and get into cs afterwards?
you can apply directly to cs
imagine reviewing a pull request eith obfuscated code 💀