We can avoid the middle pointer also just keep updating the first and second pointers - class Solution { private TreeNode first; private TreeNode second; private TreeNode prev; public void recoverTree(TreeNode root) { inorder(root); int temp = first.val; first.val = second.val; second.val = temp; } public void inorder(TreeNode root) { if(root == null) return; inorder(root.left); // Keep updating first and second which points to first and second numbers to swap if(prev != null && root.val < prev.val) { if(first == null) { first = prev; second = root; } else { second = root; } } prev = root; inorder(root.right); } }
If trying to code in python use list to store prev,first,last and middle (or prev and last if not using middle) as when prev is just declared as just an argument, it gets reassigned and will not get passed on to the next recursive call.
find the two elements which are not at it's correct place through inorder traversal vector and sorted vector. again perform inorder traversal and have a check on root element if it's equal to incorrect element swap it.
🚨[IMPROVMENT IN THE CODE]:🚨 Hello Striver Bhaiya, 1- if you would have done middle = root in the else part then you wouldnt have had any requirement of the variable "last", you can do it using only two variables. 2- You could have also used an array of size 3 instead of global variables. But if your intention to was make code simpler for others to understand then it is all fine.....👍
i also solved it using two vaiables because if in first case we can find the prev value at which the root value is less than prev then that means we find the greater element so the next voilation is always less than the first voilation so we can store last as root
Shouldn't line number 24 of C++ be , if(prev ->Val != INT_MIN &&.....) rather than if(prev!=NULL &&....) because prev has already been set to a TreeNode with a value of INT_MIN so it will never be NULL?
just using "if(root->val < prev->val)" is fine as the first root->val will always be greater than the INT_MIN so it automatically won't check for the first node.
yup, class Solution { TreeNode *prev; TreeNode *first; // TreeNode *middle; TreeNode *last; public: void inorder(TreeNode* root){ if(!root)return; inorder(root->left); // the node is not the root element if(prev != NULL and (root->val < prev->val)){ // if this is the first element if(first == NULL){ first = prev; } last = root; } prev = root; inorder(root->right); } void recoverTree(TreeNode* root) { prev = first = last = NULL; inorder(root);
I guess it works for understanding the algorithm then optimising it to first and last become easier class Solution { TreeNode *prev; TreeNode *first; // TreeNode *middle; TreeNode *last; public: void inorder(TreeNode* root){ if(!root)return; inorder(root->left); // the node is not the root element if(prev != NULL and (root->val < prev->val)){ // if this is the first element if(first == NULL){ first = prev; } last = root; } prev = root; inorder(root->right); } void recoverTree(TreeNode* root) { prev = first = last = NULL; inorder(root);
Is it not possible that there are more than two violations for example three or four violations? Why have we considered that either there will be one violation or two violations?
Bhai I think prev is never going to be NULL, because at first we are assigning it with INT_MIN and after that it always stores non-null root value. Wo condition hata ke dekho code chalega
@@Xp-Sam ha prev ko NULL kar de instead of INT_MIN tabh bhi chalega, my code without middle pointer, easy to optimize if yo examine the conditions in main function: class Solution { TreeNode *prev; TreeNode *first; // TreeNode *middle; TreeNode *last; public: void inorder(TreeNode* root){ if(!root)return; inorder(root->left); // the node is not the root element if(prev != NULL and (root->val < prev->val)){ // if this is the first element if(first == NULL){ first = prev; } last = root; } prev = root; inorder(root->right); } void recoverTree(TreeNode* root) { prev = first = middle = last = NULL; inorder(root);
Please like and share :)
What a co incidence, I was exactly studying the same problem and wasn't able to understand on my own and here comes Striver for rescue 😀😀
instead of making third variable we can also update the middle variable when there is a 2nd violation
my mom said "ye ladka kitni mehnat karta h" - what a explanation striver bhaiya
Such a brilliant explanation of the problem! Thank you very much fir helping all of us!
You are the best instructor !! Thanks a ton for this content ! You are bringing a revolution striver!
As u initialize prev as INT_MIN then u don't need to check prev != null in inorder recursive. Just correction. You are already great.
In leetcode question the values are in range of [INT_MIN, INT_MAX], so this won't work there.
excellent explanation striver bhai
Thank You So Much for this wonderful video...🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻🙏🏻
Much Love from London❤
Thankyou sir👍For always helping by your approaches
Awesome explanation
We can avoid the middle pointer also just keep updating the first and second pointers -
class Solution {
private TreeNode first;
private TreeNode second;
private TreeNode prev;
public void recoverTree(TreeNode root) {
inorder(root);
int temp = first.val;
first.val = second.val;
second.val = temp;
}
public void inorder(TreeNode root) {
if(root == null) return;
inorder(root.left);
// Keep updating first and second which points to first and second numbers to swap
if(prev != null && root.val < prev.val) {
if(first == null) {
first = prev;
second = root;
} else {
second = root;
}
}
prev = root;
inorder(root.right);
}
}
Thought same ✌️💯
This dude's neighbors get free lectures. Hope they appreciate it.
add morris traversal and we can do this problem on O(1) space as well.
LeetCode 99 problem Can be done with morris traversal
Absolutely brilliant explanation as well as mind blowing implementation of code,just loved it bhaiya.
If trying to code in python use list to store prev,first,last and middle (or prev and last if not using middle) as when prev is just declared as just an argument, it gets reassigned and will not get passed on to the next recursive call.
Hare Krishna..!
Got Placed in R & D of a Product Based Company..!
Thanks Bhaiya..!
I will tag you in Linkedln post in some time
Very helpful and thorough explanation, love it!
The logic you have given to solve this is brilliant af. GG
I always feel motivated by your passion of explaining problems👍
Thanks Man!!!
After watching your tree series i m pretty confident in Binary trees and bst 🔥🔥🔥🔥🔥🔥🔥
//first brute method
vectorv;
int i=0;
void tra(Node *root)
{
if(!root) return;
tra(root->left);
v.push_back(root->data);
tra(root->right);
}
void check(Node *root)
{
if(!root) return;
check(root->left);
if(v[i]!=root->data)
{
swap(root->data,v[i]);
}
i++;
check(root->right);
}
void correctBST( struct Node* root )
{
tra(root);
sort(v.begin(),v.end());
check(root);
}
Thank you Bhaiya
i think there is no need of " prev != null" in line 27
good video
Thank you striver bhaiya for making such a great series and it's helping me out in placement preparation
You seem to like teddy bears a lot
Thank you so much striver bhaiya for providing such an amazing content :)
find the two elements which are not at it's correct place through inorder traversal vector and sorted vector. again perform inorder traversal and have a check on root element if it's equal to incorrect element swap it.
fire hai bhau
Great explanation , thank you.
Watch these videos, and you'll never forget the importance of inorder traversal for BSTs!
Brute force Code:
class Solution {
public:
void inorderTraversal(TreeNode* root,vector&arr){
if(root==NULL)
return;
inorderTraversal(root->left,arr);
arr.push_back(root->val);
inorderTraversal(root->right,arr);
}
void recoverBST(TreeNode* root, vector&arr,int &i){
if(root==NULL)
return;
recoverBST(root->left,arr,i);
if(root->val != arr[i]){
root->val = arr[i];
}
i++;
recoverBST(root->right,arr,i);
}
void recoverTree(TreeNode* root) {
vectorarr;
inorderTraversal(root,arr);
sort(arr.begin(),arr.end());
// for(auto ar:arr)cout
We have to make variable i, a global variable. So, that it can get updated after every recursive call.
understood.
understood
🚨[IMPROVMENT IN THE CODE]:🚨
Hello Striver Bhaiya,
1- if you would have done middle = root in the else part then you wouldnt have had any requirement of the variable "last", you can do it using only two variables.
2- You could have also used an array of size 3 instead of global variables.
But if your intention to was make code simpler for others to understand then it is all fine.....👍
i also solved it using two vaiables because if in first case we can find the prev value at which the root value is less than prev then that means we find the greater element so the next voilation is always less than the first voilation so we can store last as root
Just wow, the intution was awesome.
Quite ambiguous explanation.
Great Explanation !!!
the first method can be optimised to O(n) + O(n) time, by removing the redundant sorting,
void dfs(Node* root, vector &inorder){
if(root == NULL) return;
dfs(root->left, inorder);
inorder.push_back(root);
dfs(root->right, inorder);
}
void correctBST( struct Node* root )
{
vector inorder;
dfs(root, inorder);
int ct = 0;
vector pos;
for(int i = 1; i < inorder.size(); i++){
if(inorder[i]->data < inorder[i-1]->data){
pos.push_back(i);
ct++;
}
}
if(ct == 1){
swap(inorder[pos[0] - 1]->data, inorder[pos[0]]->data);
}
else if(ct == 2){
swap(inorder[pos[0]-1]->data, inorder[pos[1]]->data);
}
}
13:55 which online coding judge or editor is that??
Amazing explanation bhaiya!
Congratulations on 3 Lakh Subscribers
even if we keep all variables and functions of class in public, code still works. But why are we keeping private for some functions and variables ?
Shouldn't line number 24 of C++ be , if(prev ->Val != INT_MIN &&.....) rather than if(prev!=NULL &&....) because prev has already been set to a TreeNode with a value of INT_MIN so it will never be NULL?
just using "if(root->val < prev->val)" is fine as the first root->val will always be greater than the INT_MIN so it automatically won't check for the first node.
but what if there are more than one nodes that are swapped?
this was smooth!
For many problems in BST,
MORRIS Inorder approach is giving Stack Overflow error (RUN TIME ERROR).
Is it same with everybody ?
Thanks for the video man.
If the inorder sequence is 3 25 7 8 10 15 20 12. Then...
Which device is used in videos?? I need one to practice.
Check out Morris Inorder traversal code related to these problem
class Solution {
public:
void recoverTree(TreeNode* root) {
if(!root){
return;
}
TreeNode*cand1=NULL;
TreeNode*cand2=NULL;
TreeNode*prev=NULL;
TreeNode*curr=root;
while(curr){
if(curr->left==NULL){
if(prev){
if(prev->val > curr->val){
if(cand1==NULL){
cand1=prev;
}
cand2=curr;
}
}
prev=curr;
curr=curr->right;
}
else{
TreeNode*temp=curr->left;
while(temp && temp->right && temp->right!=curr){
temp=temp->right;
}
if(temp->right==NULL){
temp->right=curr;
curr=curr->left;
}
else{
if(prev){
if(prev->val > curr->val){
if(cand1==NULL){
cand1=prev;
}
cand2=curr;
}
}
prev=curr;
temp->right=NULL;
curr=curr->right;
}
}
}
swap(cand1->val,cand2->val);
}
};
can someone tell me why in the last we do (prev=root ) pls if u know try to give a explanation...🙏
we love your content and we love you......🤟🖤
Perfectly explained....
Why prev = new Tree(INT_MIN)
That is not required !!!!
Pls Anyone ???
I simply made the prev node NULL and the code still got accepted.
When this Series Complete
The middle pointer can be avoided I guess!!!
czcams.com/video/k2haMtP7nvs/video.html
yup,
class Solution {
TreeNode *prev;
TreeNode *first;
// TreeNode *middle;
TreeNode *last;
public:
void inorder(TreeNode* root){
if(!root)return;
inorder(root->left);
// the node is not the root element
if(prev != NULL and (root->val < prev->val)){
// if this is the first element
if(first == NULL){
first = prev;
}
last = root;
}
prev = root;
inorder(root->right);
}
void recoverTree(TreeNode* root) {
prev = first = last = NULL;
inorder(root);
swap(first->val,last->val);
}
};
what drawing software are u using?
Why you have used middle,we can just update last instead of middle and it works fine??
czcams.com/video/k2haMtP7nvs/video.html
I guess it works for understanding the algorithm then optimising it to first and last become easier
class Solution {
TreeNode *prev;
TreeNode *first;
// TreeNode *middle;
TreeNode *last;
public:
void inorder(TreeNode* root){
if(!root)return;
inorder(root->left);
// the node is not the root element
if(prev != NULL and (root->val < prev->val)){
// if this is the first element
if(first == NULL){
first = prev;
}
last = root;
}
prev = root;
inorder(root->right);
}
void recoverTree(TreeNode* root) {
prev = first = last = NULL;
inorder(root);
swap(first->val,last->val);
}
};
@@your_name96 thanks bro btw which are u a college student?
@@justinmyth4980 Islamabad university , lahore
class Solution {
TreeNode prev;
TreeNode violation1;
TreeNode violation2;
public void inorder(TreeNode root) {
if(root == null)
return;
inorder(root.left);
if(prev != null && prev.val > root.val)
{
if(violation1 == null)
violation1 = prev;
violation2 = root;
}
prev = root;
inorder(root.right);
}
public void recoverTree(TreeNode root) {
inorder(root);
int temp = violation1.val;
violation1.val = violation2.val;
violation2.val = temp;
}
}
Great explain
Excellent explanation
Thank You : )
We dont need to check the condition if prev!=NULL ;
Understood!
Understood thanks :)
Is it not possible that there are more than two violations for example three or four violations? Why have we considered that either there will be one violation or two violations?
Because the question states that only 2 nodes will be swapped
hey guys'
Exceptional.
bhai code bahut tej explain karte ho thoda slow karo yaar
Why you need to allocate space to prev? I don’t think we need it.
czcams.com/video/k2haMtP7nvs/video.html
nice code explanation
If bst is not in correct order you will not get the preorder sorted
Thank you sir
Great video
striver rescued me here
Hey interviewer😆😅
Understood:)
Done!!
bhaiya you are great
why are we checking prev != NULL
tabhi toh compare kr payega bhai swapping ke lie
Bhai I think prev is never going to be NULL, because at first we are assigning it with INT_MIN and after that it always stores non-null root value.
Wo condition hata ke dekho code chalega
@@Xp-Sam ha prev ko NULL kar de instead of INT_MIN tabh bhi chalega, my code without middle pointer, easy to optimize if yo examine the conditions in main function:
class Solution {
TreeNode *prev;
TreeNode *first;
// TreeNode *middle;
TreeNode *last;
public:
void inorder(TreeNode* root){
if(!root)return;
inorder(root->left);
// the node is not the root element
if(prev != NULL and (root->val < prev->val)){
// if this is the first element
if(first == NULL){
first = prev;
}
last = root;
}
prev = root;
inorder(root->right);
}
void recoverTree(TreeNode* root) {
prev = first = middle = last = NULL;
inorder(root);
swap(first->val,last->val);
}
};
```
class Solution {
private:
TreeNode *first;
TreeNode *last;
TreeNode *prev;
void inorder(TreeNode* root){
if(root==NULL) return;
inorder(root->left);
if(prev->val>root->val){
if(first==NULL){
first=prev;
last=root;
}
else{
last=root;
}
}
prev=root;
inorder(root->right);
}
public:
void recoverTree(TreeNode* root) {
first=last=prev=NULL;
prev=new TreeNode(INT_MIN);
inorder(root);
swap(first->val,last->val);
}
};
```
Can I do it using the concept which you are using in the last lecture (largest bst) when the condition get wrong
largest of left
czcams.com/video/k2haMtP7nvs/video.html
13:10
Wow
💚
shouldnt first be equal to root..how come first is set equal to prev
Goat 🐐
...............
Baak bakwas krta h Khali kuch sahi se explain nhi krta h
I have done it in n time and n space using hashmap , and i was thinking my solution is best until i watched this video🥲
Awesome explanation
understood
When this Serie Complete
Tomorrow..
@@takeUforward cool
understood