Optimizing with "Bad Code"

Sdílet
Vložit
  • čas přidán 22. 12. 2023
  • Patreon: / kazestuff
    Streams: / @kazeclips
    🐦 / kazeemanuar
    MERCH: kazemerch.myspreadshop.com/all
  • Hry

Komentáře • 1K

  • @KazeN64
    @KazeN64  Před 5 měsíci +526

    2 Common Questions I'd like to answer:
    1) Why not just pass a vector pointer to the lateral distance function?
    Because load instructions under MIPS have a constant offset you can provide. By assuming how far away from the pointer the offset is, we can cover one special case in 1 cycle less and have all the other cases work in the same amount of cycles. Making a special case for the lateral distance function and then constantly repurposing it is an optimization!
    2) Why don't you just use inline assembly?
    - I need my code to be in this exact spot for cache coherency and using inline assembly mips GCC style is too much of a pain. I wish there was a way to just write assembly?? But somehow there isn't.

    • @laclica
      @laclica Před 5 měsíci +18

      would maybe another compilet like llvm clang maybe able to provide better behaviour when compiling. or maybe it's worst XD.

    • @JackWhitehead1981
      @JackWhitehead1981 Před 5 měsíci +27

      I’d love to see your work done to Goldeneye on the N64, maybe get it up to a half decent frame rate.

    • @Adolf1Extra
      @Adolf1Extra Před 5 měsíci +31

      > But somehow there isn't.
      Not sure if sarcasm, but you already built a custom GCC. Why not build GAS as well? It builds along with GCC if you configure the project with --with-gnu-as.

    • @AmaroqStarwind
      @AmaroqStarwind Před 5 měsíci +8

      You should look at the Union feature in C++, and the Restrict feature in C.

    • @multiplysixbynine
      @multiplysixbynine Před 5 měsíci +13

      You can write entire assembly functions in a separate source file and link them in. No more fighting the compiler that way.

  • @dafff08
    @dafff08 Před 5 měsíci +885

    "how much did you improve the performance?"
    "by roughly 2 fps."
    "what did it cost you?"
    "i can no longer read the code, let alone make any changes."
    "was it worth it?"
    "you bet"

    • @juanca12th
      @juanca12th Před 5 měsíci +109

      But hey, rambus go vroom vroom

    • @mariotheundying
      @mariotheundying Před 5 měsíci +42

      Gonna make the most incomprehensible code ever, not even the most advanced of AIs being able to accurately read it, to make the game 0.1% faster, worth it (dw it adds up to 0.7% with other stuff)

    • @GeorgeTsiros
      @GeorgeTsiros Před 5 měsíci +52

      "what did it cost you?"
      "the resulting binary can no longer be disassembled because i use invalid opcodes, you have to poke a NOP at certain memory locations, disassemble it and then add the missing instructions back, by hand."

    • @michaelbuckers
      @michaelbuckers Před 5 měsíci +20

      You realize it's completely worth it because it's a systems function that doesn't needs being read or changed. It's like that one fast inverse square root function. Literally who cares if it's impossible to follow?

    • @MindlessMegaLawl
      @MindlessMegaLawl Před 5 měsíci +2

      @@GeorgeTsiros 😭😭😭😭😭😭😭😭😭

  • @TheJesterElectronic
    @TheJesterElectronic Před 5 měsíci +3124

    In 5 years, Kaze will have moved on from coding entirely and will be building this game transistor-by-transistor to improve on the inefficient architecture of N64 cartridges.

    • @TheSaadtut
      @TheSaadtut Před 5 měsíci +75

      I actually laughed out loud, this is pure gold 😂😂

    • @Minty_Meeo
      @Minty_Meeo Před 5 měsíci +182

      All copies of RTYI will require the special KAZE-1 enhancement chip on-board to boost performance.

    • @mariotheundying
      @mariotheundying Před 5 měsíci +57

      At that point might as well modify the console to make it as optimized as possible

    • @kargaroc386
      @kargaroc386 Před 5 měsíci +48

      I guess the logical conclusion is Kaze pushing computer tech forward.

    • @hueluca
      @hueluca Před 5 měsíci +22

      I think the next step is him writing his own compiler

  • @FairlySadPanda
    @FairlySadPanda Před 5 měsíci +1303

    Rule 1 of systems coding: "the compiler is smarter than you are"
    Rule 2: "except when it isn't"

    • @colonthree
      @colonthree Před 5 měsíci +100

      I always go by "The compiler is not your friend." which I read somewhere on the internet a long time ago. ;w;

    • @codix__
      @codix__ Před 5 měsíci +28

      @@colonthree "YOU NEED TO BE THE COMPILER !"

    • @zombie_pigdragon
      @zombie_pigdragon Před 5 měsíci +13

      @@colonthree but it is your coworker...

    • @danieldimitri6133
      @danieldimitri6133 Před 5 měsíci +9

      Wait? Who's the compiler and who's the compilee?

    • @turbochargedfilms
      @turbochargedfilms Před 5 měsíci +41

      compiler? i hardly know her!

  • @pleasedontwatchthese9593
    @pleasedontwatchthese9593 Před 5 měsíci +871

    i always find the most unreadable code is when they start utilizing undocumented bugs in hardware because the code your looking at even if you 100% understood it, is not doing what you think it does. or when they start using undocumented instructions that do a weird combination of things. this is what makes making emulators so hard to make.

    • @dacueba-games
      @dacueba-games Před 5 měsíci +89

      "makes making emulators so hard to make" 🤣

    • @i.8530
      @i.8530 Před 5 měsíci +85

      Luckily the N64 doesn't have too much of this on the CPU front, the only bug is shown in this video. Theres also no undocumented instructions. Where for example the NES would partially execute and effectively combine multiple instructions when encountering an unknown opcode, the VR4300 (the CPU used by the N64) throws an Reserved Instruction exception instead. Deterministic cases of undefined behaviour (e.g. divide by zero) could in theory be abused, but im not sure if that ever ends up being useful.

    • @noidea5597
      @noidea5597 Před 5 měsíci +7

      ​@@i.8530Are you also a N64 programmer? You know a lot of things!

    • @Selendeki
      @Selendeki Před 5 měsíci +35

      @@noidea5597 I bet there are many people who are hobby coding on emulators that watch this channel :P

    • @pleasedontwatchthese9593
      @pleasedontwatchthese9593 Před 5 měsíci +5

      @@dacueba-games like im likely to literate too much literation

  • @TabbyKoneko
    @TabbyKoneko Před 5 měsíci +257

    I work in a codebase that is at least 60 years old. Looking at older versions written for IBM mainframes, everything looks like this. My favorite was, instead of having a boolean array for if a region had a particular property, they instead stored the machine code for "no-op" and "jump to function" where relevant and executed the array directly.

  • @3lH4ck3rC0mf0r7
    @3lH4ck3rC0mf0r7 Před 5 měsíci +497

    Man, whatever glitches you miss when you release this are gonna be wild. You're playing with extremely volatile logic alchemy here, even more unsafe than Pokémon Gen 1.

    • @KazeN64
      @KazeN64  Před 5 měsíci +327

      i had had to deal with some insane bugs before LOL

    • @javaguru7141
      @javaguru7141 Před 5 měsíci +294

      @@KazeN64 A video about some of those would be very entertaining lmao

    • @zacharybrown3010
      @zacharybrown3010 Před 5 měsíci

      ​@@javaguru7141agreed

    • @shauas4224
      @shauas4224 Před 5 měsíci

      @@javaguru7141 this ++++

    • @KazeN64
      @KazeN64  Před 5 měsíci +273

      @@javaguru7141 oh that could be cool!

  • @JohnSmith-xv1tp
    @JohnSmith-xv1tp Před 5 měsíci +854

    As a software engineer myself, this was an amazing implementation of optimization and horror story of indecipherable deep magic. Nice job as always 👍

    • @uwirl4338
      @uwirl4338 Před 5 měsíci +41

      What do you work on? 99% of software engineers work with Java or C# and barely know what a clock cycle is

    • @joseiparra9944
      @joseiparra9944 Před 5 měsíci

      ​@@uwirl4338yup but besides hating it so much Java brings bread to the table

    • @JohnSmith-xv1tp
      @JohnSmith-xv1tp Před 5 měsíci

      @@uwirl4338 Java, server management. So my optimization is more in the form of SQL query optimization, data manipulation, multithreading, etc. However, I did dabble in asm and low level C in College. Also, I love watching videos that go into such detail for games, like Kaze Emanuar or Retro Game Mechanics Explained, or plenty of other speedrunning channels that talk about things like exploiting arbitrary code execution vulnerabilities!

    • @christophmayer3991
      @christophmayer3991 Před 5 měsíci

      @@uwirl4338 Well, most software engineers (at least those using Java and C#) work on some sort of "business software". And for this type of software maintainability, extendibility and "getting it done on schedule" is way more important than performance. In the end it's usually a lot cheaper to throw more cores or more memory at a problem, than paying a guy 6+ weeks to optimize the code. And if it is ever necessary to optimize the code, it's usually sufficient to switch to some other algorithm or do "high level" optimizations, not actually chasing a few clock cycles in each function.
      Oh and obviously: Java and C# aren't even compiled into machine code ahead of time, so all of those optimization schemes wouldn't work in the first place. Never the less it's damn impressive to see these techniques in action and I love hearing about them.

    • @widget5963
      @widget5963 Před 5 měsíci +39

      Honestly I think most of the functions here (except the last one??) would be fine if they were explained with a page-long docstring explaining the theory behind the behavior of each function.
      Novel-length docstrings are also a good signal for junior devs to stay away from that code.

  • @SaHaRaSquad
    @SaHaRaSquad Před 5 měsíci +423

    It feels like every video takes me even deeper into a rabbithole with more and more cursed and even cleverer tricks.
    And it's always so interesting.

  • @JamieBainbridge
    @JamieBainbridge Před 5 měsíci +205

    For anyone thinking of implementing this generally, note Kaze is optimising for his specific purpose on his specific system and his specific compiler, and is testing everything in Compiler Explorer. Don't start doing this stuff needlessly in your own code blindly just "because Kaze said faster". If you're not writing an optimised N64 game then you need to do the profiling, research, and proof work all over again. Plus you actually need to save 1 or 2 cycles, which is unlikely on any x86 computer made in the last 30 years.

    • @keiyakins
      @keiyakins Před 5 měsíci +68

      Plus you have to be super careful not to over-optimize for a specific implementation of x86_64, which then becomes horribly slow or even downright broken on others. These sorts of micro-optimizations are almost never worth implementing unless your target hardware is 100% fixed.

    • @ukyoize
      @ukyoize Před 5 měsíci +16

      And also,compilers nowadays arepretty smart aboit compiling to archetectures that are not 20+ years obsolete.

    • @KazeN64
      @KazeN64  Před 5 měsíci +75

      i'm using modern GCC unfortunately

    • @cylemons8099
      @cylemons8099 Před 5 měsíci +9

      @@KazeN64 Is gcc's mips optimizations as good as its x86 optimizations? Or does architecture not affect how "smart" gcc is?

    • @magfal
      @magfal Před 5 měsíci +10

      I wouldn't be surprised if James Lambert is sitting there taking notes for potential optimizations in Portal 64 every time Kaze releases a new video.

  • @leroymilo
    @leroymilo Před 5 měsíci +159

    Oh my god, this was amazing, the ending line "you're welcome" is pure comedy gold. I'm never gonna use any of this but I am sending this to as many people as I can.

  • @pleasedontwatchthese9593
    @pleasedontwatchthese9593 Před 5 měsíci +274

    in some old games that super optimizations in the mid to late 90s i saw that in their source code they use to keep 2 version. A more clean version for porting to other systems and a dirty one that was platform specific. I remember some games had both a C and ASM version in some cases.

    • @KazeN64
      @KazeN64  Před 5 měsíci +153

      i'm surprised they actually cared that much to optimize code. that's a neat way of handling it. luckily for sm64, most of the functions still have an equivalent of the base decomp if anyone wants to port this stuff. (i also usually leave a pure C version of the code above it for everyone to be able to figure out what the code is supposed to do)

    • @uwirl4338
      @uwirl4338 Před 5 měsíci +34

      ​@@KazeN64Why do you "force" gcc to produce the machine code you want instead of just implementing the function in assembly? Is it the calling overhead?

    • @KazeN64
      @KazeN64  Před 5 měsíci +96

      @@uwirl4338 its just really annoying to do inline assembly in GCC. it throws so many errors. it's easier to get it right by just throwing in small assembly snippits into the C imo

    • @williamdrum9899
      @williamdrum9899 Před 5 měsíci +6

      @@KazeN64 I agree, the syntax is horrendous and doesn't feel like asm as all

    • @Alibaba-id4dw
      @Alibaba-id4dw Před 5 měsíci +1

      They made so many games, but rarely released source code for most of them.

  • @natalie5947
    @natalie5947 Před 5 měsíci +96

    This reminds me of the story of Mel the "Real Programmer" from the jargon files. Utterly indecipherable code which nonetheless is so good it's practically magic.

    • @mondobe
      @mondobe Před 5 měsíci +8

      And Kaze even made the impossible blackjack game with SM64 Chaos Edition…

  • @rauru8570
    @rauru8570 Před 5 měsíci +147

    The 'goto' part got me thinking the next step here would be to implement a N64 specific compiler

    • @KazeN64
      @KazeN64  Před 5 měsíci +143

      i already have some n64 specific tricks in this compiler! its a custom gcc build.

    • @the_kovic
      @the_kovic Před 5 měsíci +16

      @@KazeN64 Are they N64-specific or your-game-specific? Is your GCC fork public? I can imagine the libdragon guys being interested in this (unless they already implemented the same tricks in their toolchain themselves).

    • @KazeN64
      @KazeN64  Před 5 měsíci +45

      @@the_kovic easyaspi made it and it is publically accessible! although she's only posted it in my discord. but i have the custom build linked in this repo's readme

    • @thepuzzlemaster64
      @thepuzzlemaster64 Před 5 měsíci +10

      @@KazeN64
      Wait, since this is a custom fork of gcc. Is there a way to patch-in a sort-off assembly passthrough in the compiler, so that you can write in both C and Assembly without doing the weird inline assembly trick you mentioned?
      Probably overthinking things as usual, but who know.

    • @williamdrum9899
      @williamdrum9899 Před 5 měsíci

      I've had this idea for a while but I'm not sure how to implement it. It would basically be like Godbolt Compiler Explorer but it also showed you clock cycles. Like if you highlighted a section of code, you know how it shows the total character count? Imagine that but it also assembled it and displayed the byte count and clock cycles.

  • @moistness482
    @moistness482 Před 4 měsíci +11

    There is something just beautiful in writing code that is optimized so "badly" that sometimes it doesn't even compile properly

  • @MrCinico
    @MrCinico Před 5 měsíci +402

    Good video 👍 (it came out 2 minutes ago and theres no way i watched it all)

    • @KazeN64
      @KazeN64  Před 5 měsíci +185

      👍👍👍👍

    • @JustJory
      @JustJory Před 5 měsíci +35

      👍👍👍👍

    • @b3x206
      @b3x206 Před 5 měsíci +26

      👍👍👍👍

    • @2002_tanaka
      @2002_tanaka Před 5 měsíci +25

      👍👍👍👍

    • @evilgibson
      @evilgibson Před 5 měsíci +13

      So , a Gamespot review?

  • @Badspot
    @Badspot Před 5 měsíci +37

    Most of the time I treat math functions as black boxes anyway, so the fact that an evil wizard built them with black magic doesn't bother me. Unless something goes wrong and I have to open the box...

  • @SnackLive
    @SnackLive Před 5 měsíci +141

    i love how i technically understand what i just saw while at the same time i don't understand the level of wizardry this guy is performing

    • @wallywild5088
      @wallywild5088 Před 5 měsíci +7

      Exactly this honestly

    • @Cybertronic72388
      @Cybertronic72388 Před 5 měsíci +3

      Same. I mainly deal with powershell and .Net and there are times that I don't like the way the interpreter handles something, so I end up calling a .NET class because its faster at the expense of code readability.
      But hey, if I am needing it to do this thing hundreds of times within a large dataset it is worth it.
      Always add comments in case you forget why.

  • @kleinesfilmroellchen
    @kleinesfilmroellchen Před 5 měsíci +31

    As someone who's intimately familiar with the RISC-V instruction set, it's interesting to see how MIPS, the N64's instruction set, is so similar that most optimizations would still apply to a RISC-V system. A stand-out example for me was the global pointer optimization avoiding a two-byte LUI-sequence at 4:11.

    • @Sauraen
      @Sauraen Před 5 měsíci +19

      RISC-V was based on MIPS. You can think of it as if MIPS was designed again but with an extra ~25 years of experience.

  • @tbird81
    @tbird81 Před 5 měsíci +11

    5:55 first answer on stack overflow is always one saying your question doesn't make sense.
    I'm surprised it wasn't marked as a duplicate.

    • @KazeN64
      @KazeN64  Před 5 měsíci +11

      this has been posted before.
      thread closed

  • @murpyh4002
    @murpyh4002 Před 5 měsíci +8

    i like the slow pan to the "This doesn't make sense" reply on the stackoverflow page

  • @TheOriginalTraz64
    @TheOriginalTraz64 Před 5 měsíci +13

    The footnote of "I use a custom GCC build" is insane enough on its own for a whole video

  • @memyselfishness
    @memyselfishness Před 5 měsíci +61

    I love insane code techniques like this, even if I don't understand totally normal code techniques

  • @bastardferret869
    @bastardferret869 Před 5 měsíci +240

    "This might get you fired from your job, but it makes our rambus go vroomvroom, so I'd say it's worth it."
    It's always worth it.

  • @sw33t.angela
    @sw33t.angela Před 5 měsíci +248

    Kaze: Uses "goto" to swap logic for instruction caching
    Me: YOU WHAT?!
    Kaze: Overwrites functions with memcpy for a properly optimized call path to avoid bugs per console
    Me: *I AM CALLING THE POLICE!*

    • @zitronenwasser
      @zitronenwasser Před 5 měsíci +11

      i have honestly never seen the goto thing before, both are illegal but i'll permit it I'vd overwritten code with raw machine code bytes at runtime before. e.g. a E8 Call on x86.
      E8 00 00 00 64
      calls func 100 bytes after end of that instruction

    • @undefinednan7096
      @undefinednan7096 Před 5 měsíci

      How do you think dynamic linking, or loading executables into memory, for that matter, works? Also, lookup STT_GNU_IFUNC

    • @GreyWolfLeaderTW
      @GreyWolfLeaderTW Před 5 měsíci +22

      I couldn't read your "YOU WHAT?!" in any voice but Incidental 6's (from Spongebob). You know which one I am talking about.

    • @reed6514
      @reed6514 Před 5 měsíci

      😂

    • @williamdrum9899
      @williamdrum9899 Před 5 měsíci +4

      ​@@GreyWolfLeaderTW "You asked for a couple of ice cubes, but I only put in one!"

  • @Armameteus
    @Armameteus Před 5 měsíci +17

    _Kaze's next video:_ "Now we're going to delve into the apocrypha of the forbidden Old Tongue spoken only by native R'lyehn because it'll save us a whole 3 cycles and regular code just won't cut it."

  • @1ups_15
    @1ups_15 Před 5 měsíci +52

    DAMN those are some insane micro optimizations, when you said you sacrificed readability for performance, I didn't think it would be THAT bad xd

    • @reed6514
      @reed6514 Před 5 měsíci +2

      I hoped it would be even worse! 😂

  • @qlum
    @qlum Před 5 měsíci +27

    Personally, I see no problem sacrificing readability for performance, as long as you A document it, and B the performance gain is relevant for your use.

  • @Minty_Meeo
    @Minty_Meeo Před 5 měsíci +14

    7:04 You can avoid this issue entirely by moving the decrement of the loop variable into the body of the loop so it executes *after* the loop condition and *before* the first loop iteration. This is also very useful for decrementing loops that use unsigned integers.

  • @alsen99
    @alsen99 Před 5 měsíci +43

    At this point you will end up rewriting SM64 on assembly for performance 😂

  • @TheMAZZTer
    @TheMAZZTer Před 5 měsíci +25

    Back in the day running your for loops backwards was a huge time saver in JavaScript running under Internet Explorer 6. Because it was Internet Explorer.
    Just have to be careful the execution order of the items being looped through doesn't matter...

    • @williamdrum9899
      @williamdrum9899 Před 5 měsíci +3

      It's always better to run them backwards. But I'm guessing back then the compiler didn't rewrite them as backwards for you?

    • @tolkienfan1972
      @tolkienfan1972 Před 5 měsíci +1

      This was a trick I used to use back when my main PC was Z80 based. That was a long time ago. 😁

    • @williamdrum9899
      @williamdrum9899 Před 5 měsíci +1

      @@tolkienfan1972 I'd even go so far as to store my data backwards sometimes if it needed to be in a certain order. Makes me wish assemblers supported something like:
      .backwards
      db &05, &10, &15, &20
      .endb

  • @Minty_Meeo
    @Minty_Meeo Před 5 měsíci +80

    1:45 The lie you tell the compiler here is a neat trick, but I wonder of the cast can be avoided with an assume attribute instead to just tell the compiler that the value is in a valid range?

    • @KazeN64
      @KazeN64  Před 5 měsíci +80

      oh i didnt know that was a thing to use

    • @tolkienfan1972
      @tolkienfan1972 Před 5 měsíci

      ​@@KazeN64I've seen an ASSUME(x) macro implemented as if(!(x)) __builtin_unreachable();

    • @gfasterOS
      @gfasterOS Před měsícem

      @@tolkienfan1972gcc's attribute assume is even smarter, since it doesn't semantically execute the code. That means you can tell it to assume things about the result of variable modifications.

    • @tolkienfan1972
      @tolkienfan1972 Před měsícem

      ​@@gfasterOS I guess that's new. Well, new to me

  • @DoobooDomo
    @DoobooDomo Před 5 měsíci +14

    Re: 4 this is so cursed and amazing
    Re: 7 separating the "hot" and "cold" branches of a function is a good one. There are a few variants of this that may or may not help (usual caveats: depends on arch and runtime patterns). Instead of using "goto" it might be better to call a separate non-inline function. You can put all the "cold" branches in a separate section, so that more of your "hot" paths are in cache. In cases when the "hot" path is very small and common, you could also inline the hot path.
    Re: 13 at some point it is clearer to just go full asm :)

  • @RottenMuLoT
    @RottenMuLoT Před 5 měsíci +12

    Well, tbh the principles are more straightforward than that. When you write code, your very first objective is to make it produce the desired result or outcome. Second, you make it robust - you take into account edge cases and variations. Third, you optimize it. And you have to do it in that order specifically since there is no sense of optimizing a code that doesn't work.
    And when you optimize you basically sacrifice maintainability - aka you don't expect to change that code much ever again, it is the dead end.

  • @Smoopadoop
    @Smoopadoop Před 5 měsíci +24

    as a gamedev of intermediate skill, i feel like this video is expanding my brain at such a dangerous speed that it will be permanently damaged. perfect video, i'll watch as many of these as you make

  • @muha0644
    @muha0644 Před 5 měsíci +4

    YES! This is how C/C++ was meant to be used!

  • @benjaminlefebvre1866
    @benjaminlefebvre1866 Před 5 měsíci +9

    I'm pretty sure casting a function pointer to another one with a different return type would be undefined behavior if you didn't build for a single platform. It's funny in a sense, you don't have to ever worry about undefined behavior since you can always test to see what the n64 does.

    • @KazeN64
      @KazeN64  Před 5 měsíci +14

      that seems like something that would be undefined in terms of the outcome but it would have a pretty clear definition as to what it should compile to
      idk the whole idea of "undefined behavior" kinda vanishes when you have 1 compiler and 1 architecture. everything's defined by how the compiler works in the end (assuming there is no random noise it pulls from)

    • @williamdrum9899
      @williamdrum9899 Před 5 měsíci +5

      ​@@KazeN64Pretty much, I always get annoyed when people say "tHe cOmpiLeR cOuLd dO wHateVer iT waNtS!"

  • @tom_forsyth
    @tom_forsyth Před 5 měsíci +19

    6:52 - same with 68000 - it has a "DBRA" instruction - "Decrement and Branch", which decrements and branch if not -1. However this means you MUST write:
    for ( i = count-1; i >= 0; i-- )
    This will NOT produce DBRA (at least not with my version of GCC):
    for ( i = count; i > 0; i-- )
    ...even if "i" is not used in the loop body! Instead it does a standard SUBQ+JNE which is slower. Same trick, but an annoyingly subtle MIPS-vs-68k difference.

    • @williamdrum9899
      @williamdrum9899 Před 5 měsíci +1

      That is so frustrating. When I'm doing 68k asm I usually would do something like this:
      foo:
      MOVE.W #9-1, D0
      DBRA D0, foo
      for a loop that is intended to execute 9 times

  • @LordBordNoob
    @LordBordNoob Před 4 měsíci +3

    8:15 I work as a graphics programmer for an engine at my job and this style of coding is incredibly common on the low level parts of the rendering pipeline. I always thought the person who wrote these was insane, but now I finally understand.
    *They really are insane*

  • @AndresElPatronFH
    @AndresElPatronFH Před 5 měsíci +30

    I love these videos so much because I know nothing about coding but I watch them like I get it.

    • @reed6514
      @reed6514 Před 5 měsíci +5

      I've been coding for over a decade, and i kinda feel the same lol.
      There's a lot i get, but when he gets into the bit shifting i just have to trust him.

  • @im-essi
    @im-essi Před 5 měsíci +5

    great video, i haven't cried this much in years.

  • @brunoldo
    @brunoldo Před 5 měsíci +26

    I chose computer science because of you!

  • @badasson8825
    @badasson8825 Před 5 měsíci +6

    Local yoshi casts ancient voodoo magic in old videogame and create man-made horrors beyond our comprehension in Orlando, Florida.

  • @jacklawsen6390
    @jacklawsen6390 Před 5 měsíci +118

    As someone who's coded games that fit in a few hundred bytes, I see this as an absolute win.

    • @EndOfForever
      @EndOfForever Před 5 měsíci +8

      Boot sector games?

    • @jacklawsen6390
      @jacklawsen6390 Před 5 měsíci +39

      @@EndOfForever In that size range, sometimes smaller. A while ago I made a version of Snake that fit in a Tweet, or under 280 bytes.

    • @Dwedit
      @Dwedit Před 5 měsíci +4

      Games for TI83 calculators can be pretty small if done well. I made a 5-level puzzle-platformer in around 1.5kb once. But the Bubble Bobble game I made was much bigger, somewhere near 22K.

    • @mikafoxx2717
      @mikafoxx2717 Před 5 měsíci

      ​@@jacklawsen6390jeez, that's barely larger than wozmon, and even that was pretty damn small for what it did.

  • @alefy_san
    @alefy_san Před 5 měsíci +16

    You are legend, Kaze. I thought I was smart for using function pointers with duplicate functions to avoid if conditions, but this is on another level!

    • @williamdrum9899
      @williamdrum9899 Před 5 měsíci +4

      Its really useful for hardware interrupts. On gameboy and genesis I point the vectors to uninitialized RAM and memcpy the desired interrupt for a particular level. There's no sense in wasting time checking a condition over and over when you can just check it once

  • @Harsooo
    @Harsooo Před 5 měsíci +8

    I love in-depth videos like these; great work!

  • @derfliegendehollander7636
    @derfliegendehollander7636 Před 5 měsíci +11

    I love your videos so much, optimization exactly like this is my favorite activity on the planet. Seeing a new video from you is like christmas coming early.

  • @dukereg
    @dukereg Před 5 měsíci +5

    At some point it's clearer to write the exact procedure you want in assembly than to try to trick a compiler into generating the exact assembly you want with cryptic hacks. You have reached that point. 😛

  • @Merrinen
    @Merrinen Před 5 měsíci +46

    Just as a potential idea you could "document" some of the hardest functions by writing tests against them, assuming you don't have any yet.

    • @Eckster
      @Eckster Před 5 měsíci +16

      Or having the clean code versions available somewhere to indicate what they're supposed to be equivalent to.
      I know Kaze has said there are usually equivalent function names in the base decomp project, but I'd love to see optimized, even if not fully, versions of those, but with readability still intact, if available.

  • @b4ttlemast0r
    @b4ttlemast0r Před 5 měsíci +11

    It's scary to think, but it seems like that self modifying code trick could actually make a big impact in some real use cases. I mean you can potentially save millions of if-checks with it.

    • @nixel1324
      @nixel1324 Před 5 měsíci +1

      I have done something similar in a Javascript game I'm working on. I had no idea if it was even faster or anything, I just thought it was cool that I could do it. I used it for remapping keyboard inputs to different functions depending on if you're in a menu, a map, a battle, etc.

    • @TwilightFlower9
      @TwilightFlower9 Před 5 měsíci +4

      thankfully, protected mode saves us from even having to consider that on modern CPUs

  • @The_Mister_E
    @The_Mister_E Před 5 měsíci +31

    And so now we know why the N64 was the "less performant" console in spite of the lack of disc read times.
    To squeeze all the potential it had out of it, you had to be a fluent practitioner of the dark arts, on top of breaking several coding Geneva convention guidelines.

    • @KazeN64
      @KazeN64  Před 5 měsíci +35

      fortunately all of these just save a few microseconds here and there. i'm sure other consoles had similar dark art shenanigans you could do haha

    • @balala4641
      @balala4641 Před 5 měsíci +4

      @@KazeN64 gotta squeeze as much as you can out of the 16k microseconds you get per frame

    • @williamdrum9899
      @williamdrum9899 Před 5 měsíci

      I imagine most of this video applied to playstation as well

  • @hugjuffs
    @hugjuffs Před 5 měsíci +3

    I wish each of these videos had before and after benchmarks. I love seeing FPS gains or even microsecond gains.

  • @jimmyhirr5773
    @jimmyhirr5773 Před 5 měsíci +6

    The compare with zero trick also works on the NES, SNES, and all other 6502-based systems. Whenever you do an arithmetic operation, it sets the equal and carry flags with an implicit comparison to 0.

    • @williamdrum9899
      @williamdrum9899 Před 5 měsíci +2

      Even LDA implictly compares to zero!

    • @erkinalp
      @erkinalp Před 5 měsíci

      On x86 too, thanks to the zero flag

    • @williamdrum9899
      @williamdrum9899 Před 5 měsíci

      @@erkinalp Yep, that's why we use "test eax, eax" so we don't need to encode 4 bytes of zeros

  • @SeishukuS12
    @SeishukuS12 Před 5 měsíci +18

    I've always loved just how cursed console optimizations are, good work!

  • @strawmanfallacy
    @strawmanfallacy Před 5 měsíci +9

    This is the most interesting video series I've ever seen. I want more exactly like this for other games or pieces of software we're not meant to have the source code for.

    • @olzhas1one755
      @olzhas1one755 Před 4 měsíci

      I would really be interested in seeing if Goldeneye 64 can be optimized to run at a stable 30 FPS.

  • @gusgarrison9211
    @gusgarrison9211 Před 5 měsíci +2

    Audibly said "Oh my fucking god" when you said self-modifyong code. You madman. You artist.

  • @AbAb-th5qe
    @AbAb-th5qe Před 5 měsíci +3

    The abs and atan2 optimisations will come in handy some day. Thanks 😊

  • @LexTheCat
    @LexTheCat Před 5 měsíci +6

    Yay! New kaze video!

  • @salsspar2132
    @salsspar2132 Před 5 měsíci +1

    this was a beautiful video. thank you

  • @kasamialt
    @kasamialt Před 4 měsíci +1

    I've heard many people talk about decrementing loops being faster over the years, and many people also claim it's false, but this is the first time I've heard anyone so clearly explain that it's about the comparison against zero. It all makes sense now.

  • @NachostheXth
    @NachostheXth Před 5 měsíci +5

    Kaze is sounding more like a villain every day
    I understood maybe 10% of the video but it was a good time regardless, looking forward to next time!

  • @GanerRL
    @GanerRL Před 5 měsíci +4

    Bro is approaching the Kolmogorov complexity for most performant m64 game

    • @xdanic3
      @xdanic3 Před 5 měsíci

      Didn't know that concept. And yeah, that's a wet dream come true.

  • @DeadCatX2
    @DeadCatX2 Před 5 měsíci +2

    An excellent video! I laughed so hard at some of these, partially bc I've had to do the same with microcontroller compilers. When you've got a dinky little 12 MIPS mcu, counting cycles can be important, and improperly handled casts and such by the compiler can eat into that.

  • @heavygaming6596
    @heavygaming6596 Před 5 měsíci

    I absolutely love videos like these, thank you

  • @someonecalledrichardthehuman
    @someonecalledrichardthehuman Před 5 měsíci +5

    Hmm pretty interesting optimization techniques, most of the time idk whats actually happening but your explanation is very understandable, great video Kaze!

  • @secondarycontainment4727
    @secondarycontainment4727 Před 5 měsíci +4

    Kaze, I am a huge fan of optimization and "form fits function". Even though I don't understand most of what you are doing here - I love watching this content from you. Thank you and keep it up!

  • @dot32
    @dot32 Před 5 měsíci +2

    You need to write a compiler

  • @arciks11
    @arciks11 Před 5 měsíci +11

    Kaze wants every every line of his code to be tagged with "WTF" code commentary by a 3rd party looking at the code. The same way Fast Inverse Square Root was commented on in Quake 3 code (Not Doom).

  • @EpochFlame
    @EpochFlame Před 5 měsíci +5

    good video explaining deranged optimization specific to your hardware, love to see it

  • @Superdavo0001
    @Superdavo0001 Před 5 měsíci +26

    This really feels like we're delving into the dark arts at this point, learning things mortal man was not meant to know & developing dark powers out of reach of the gods.
    All to make Mario run a little bit better!

    • @lpfan4491
      @lpfan4491 Před 5 měsíci +4

      *insert meme about dark side of the force and unnatural abilities*

  • @fb39ca4
    @fb39ca4 Před 4 měsíci

    Once I was writing a loop in assembly that did two different things at several points based on a boolean state variable. Instead of checking the variable each time and branching I just wrote two variants of the loop and jumped between the equivalent point in the loop whenever I wanted to change the variable, eliminating said variable.

  • @ABaumstumpf
    @ABaumstumpf Před 5 měsíci +6

    Had a coworker that wrote a small script in python cause it is "So easy and fast to write". When he used it he noticed it was too slow to be used at all (simple test-cases with inputsizes in the range of maybe 50 elements would work, we needed thousands). Then he spent weeks trying to make his python faster.
    He ended up writing it in C++ and was done in 2 weeks (and a couple thousand times faster program).

    • @reed6514
      @reed6514 Před 5 měsíci +1

      I did some advent of code challenges in PHP this year & BOY IS IT SLOW.
      One of my solutions was a brute force of about 4 billion operations, which i broke into 10 processes & then each process took about 3-5 minutes.
      Then someone in YT comments said they brute forced in Rust & got it done in a minute or two.
      To make it better, my brute force didn't even get me the right answer! Lol.
      Also by "operation" i mean ... a loop, basically. Each loop had quite a few things to do.

    • @reed6514
      @reed6514 Před 5 měsíci

      There was another advent of code challenge i did in PHP that was computationally intense (+ LOTS of memory access) where i was able to optimize the heck outta my php though & actually make it work.
      That was my first encounter with memory bottleneck being a real problem.

    • @ABaumstumpf
      @ABaumstumpf Před 5 měsíci

      @@reed6514 Well PHP is (up till very recently) an interpreted scripting language. Will take some time to run anything compute-intensive. It is a wonder how powerful a website-modifying scrip has become.

  • @Match451
    @Match451 Před 5 měsíci +4

    I wonder if there are any things the compiler maintainers could do to make Kaze's life easier in implementing these optimizations.

  • @jeremyandrews3292
    @jeremyandrews3292 Před 5 měsíci +2

    Generally when writing a lot of complex stuff like this where it's not obvious what it does, it's not so much that you can't do it, but they really want you to write code comments along the way to explain to other people why it's done that way and warn them what kind of scenarios could break it. So the more inline assembly you use, the more code comments you need to go along with it... that is to say, the less human-readable the code itself is, the more you have to compensate by having human-readable translations alongside of it. For that code, you'd end up writing a novel explaining it to any programmer that comes after you... and most people would rather just make the code itself more readable than spend half a day explaining their heavily-optimized code to a hypothetical newcomer in the code comments. But when it's absolutely necessary, you will see tricks like this used along with extensive documentation (and sometimes cursing and F-bombs about how pissed they are they had to write the code this way and how much they hate the compiler depending on how professional they are).

    • @terryscott524
      @terryscott524 Před 5 měsíci +1

      or for when you come back to it next week

  • @jacobrosen
    @jacobrosen Před 5 měsíci +1

    I love almost silly levels of optimizations like this!

  • @undefinednan7096
    @undefinednan7096 Před 5 měsíci +11

    First, great video, but I'd like to point out a few things for people who might not know them. A key thing that cannot be emphasized enough is that you need to measure whether these sorts of optimizations actually speed up your code.
    For example, the self-modifying code trick will often make your code slower since to make it work reliably you'll need to invalidate the icacheline (and flush the dcacheline if you used cached access), and the possible extra reads from RAM will often cost you more than you gain. Also, I think you know this, but for other people's benefit, you want to modify code while you're executing far away from it (MIPS cpus wont execute modified instructions if the instruction is already in the pipeline -- this isn't so bad for the VR4300, which only has a 5-stage pipline and is in-order scalar) and in bulk (so you can minimize the number of cache flushes needed). The more modern the CPU, the worse self-modifying code is in general.
    Also, if you need to do a ton of BS to get the compiler to output a specific sequence of instructions, perhaps you should just code the function or performance critical piece of code part in assembly. In the example of atan2s, it already has large portions of assembly, so making the code less fragile is probably worth it.
    For the struct Surface, 0x16 isn't 4 byte aligned, so the compiler should automatically insert the padding, so the two structs should have exactly the same layout, which agrees with the offsets in the code you show onscreen (although it could be more clear to explicitly show the padding).

    • @KazeN64
      @KazeN64  Před 5 měsíci +7

      yeah i'd love to just write it in assembly, but i find it to be a huge pain to write inline assembly under GCC. it never seems to work right beyond small snippits.
      yeah i added the padding on the left side manually just to showcase this better. (although there is probably some compilers that would realign the struct on the right to make the struct smaller? or at least, there should be some settings that do that automatically for you)

    • @ederbarrero5585
      @ederbarrero5585 Před 5 měsíci

      ​@@KazeN64I'm pretty sure that "setting" is just the packed attribute ( __attribute__((packed)) ) which will place the struct members such as they occupy the least amount of space (byte-wise) even if it breaks type alignment rules (like ints needing to be 32bit aligned)

  • @daimahou3951
    @daimahou3951 Před 5 měsíci +6

    ... What I'm getting from this is that when you will be sent back in time to make the fully optimized Super Mario 64, they will either kick you out for writing this code or praise you for your genius.

    • @mylittleparody2277
      @mylittleparody2277 Před 5 měsíci

      They didn't had the same compiler.
      So, some of his hacks won't be usable.
      Back in the day, if you wanted power, you wrote assembly functions and used C as "super assembly".

  • @mihaleben6051
    @mihaleben6051 Před dnem

    Reminder: the possibilites of just a combination of 2 bits for every bit
    Is the sum of the assigned numbers to bits.
    Basically, a factorial bit for addition
    Its 1+2+3...
    You get it.
    And 4 bits is an nightmare. Especially in minecraft.

  • @shauas4224
    @shauas4224 Před 5 měsíci

    Outputs off-by-one error every 8787 angles got me so good

  • @obluda_
    @obluda_ Před 5 měsíci +8

    Wouldn't writing some functions entirely in assembly be more readable than having to inline some asm instructions here and there to force the compiler into producing the asm that you want? At least for short functions.

    • @KazeN64
      @KazeN64  Před 5 měsíci +15

      probably, but writing inline assembly for mips gcc is torture, i can never get it to just go into the rom and it throws millions of errors lmao

    • @angeldude101
      @angeldude101 Před 5 měsíci +2

      GCC is also very enthusiastic about exploiting undefined behavior, and will usually use it to do things you don't want. You have to deliberately disable certain optimizations in order to get away with faster code, which will just make code elsewhere slower.

    • @undefinednan7096
      @undefinednan7096 Před 5 měsíci +3

      ​@@KazeN64 what about writing out-of-line assembler then and just linking it in as a separate object file

    • @Ehal256
      @Ehal256 Před 5 měsíci +1

      ​​@@undefinednan7096you don't get the benefit of inlining in that case.
      I would definitely recommend more inline asm, but I'm working in 68k which is probably a bit easier to write than mips. You do get used to gcc's inline asm syntax eventually, it's all over my engine now.

    • @undefinednan7096
      @undefinednan7096 Před 5 měsíci

      @@Ehal256 good point, and I don't think you could use LTO to easily fix that. I'm not so sure that 68k assembler is actually easier to write than MIPS asm (a lot of places used to use MIPS as the intro to asm)

  • @bstlang
    @bstlang Před 5 měsíci +6

    On reverse loops, instead of looping fron N to 1, would it be useful to loop from N-1 to 0 with this? 'for (i = N; i--; )'

  • @williamdrum9899
    @williamdrum9899 Před 5 měsíci

    0:38 That brought a tear to my eye. It's so beautiful I'm speechless

  • @iro4201
    @iro4201 Před 5 měsíci

    This is dedicated, thank you.

  • @SimonZerafa
    @SimonZerafa Před 5 měsíci +3

    Good Video. It came out 21 minutes ago so I have watched it all 😁

  • @anzhel3268
    @anzhel3268 Před 5 měsíci +7

    I thought I was the only one doing cursed stuff for fun!
    Also thanks for the fast absi, that's quite common so it will help. ♥

  • @hakurou4620
    @hakurou4620 Před 5 měsíci +1

    The comment about your first ever programming undertaking reminded me of a elementary school friend i had who spent their time, at ten years of age, hacking mario world by simply editing the rom directly with a hex editor. Great video!

  • @licentioushowler3400
    @licentioushowler3400 Před 5 měsíci +1

    WOW, INCREDIBLE

  • @dukemagus
    @dukemagus Před 5 měsíci +3

    10:15 I know only one guy that ever tried to use self modifying code for performance gains. He gave up because debugging became nearly impossible

  • @razorblade413
    @razorblade413 Před 5 měsíci +6

    since readability is going out of the window, i think kaze should have a code copy of the engine before this dramatic changes, because when he released the source code of rtyi it will be so hard to read and tightly coupled to its function that no other hacker could made a new hack from that source code.

    • @Minty_Meeo
      @Minty_Meeo Před 5 měsíci

      That's a lot of effort at no benefit to Kaze.

    • @razorblade413
      @razorblade413 Před 5 měsíci

      @@Minty_Meeo it is just having a copy of the previous code. With all the previous performance improvements it should be enough for the majority of hackers.There is no need to further improvements from 99% of the rest of mario 64 devs.

    • @Minty_Meeo
      @Minty_Meeo Před 5 měsíci

      The git commit history is probably all you will get.

    • @inkoalawetrust
      @inkoalawetrust Před 5 měsíci +2

      I think he does also keep actually readable C versions of all the functions above the bizzaro optimized versions for that purpose.

    • @razorblade413
      @razorblade413 Před 5 měsíci

      @@inkoalawetrust that's good to know.

  • @brightclouds98
    @brightclouds98 Před 5 měsíci

    wow this is a lot of work. Impressive.

  • @ndc5544p
    @ndc5544p Před 5 měsíci

    the wizard has posted!
    Merry Christmas Kaze! :)

  • @AK-vx4dy
    @AK-vx4dy Před 5 měsíci +3

    You just exploded heads of many cleancoders 🤯😜
    In 8-bit assembly were not caches but pressing every cycle form hardware was a norm 😂
    Nice tricks by they way 💪

  • @pokeyjojo5691
    @pokeyjojo5691 Před 5 měsíci +3

    I really hope he backed up the old codebase because wow, this optimizations are getting insane

  • @TheLordoftheDarkness
    @TheLordoftheDarkness Před 6 dny

    13:03 this was very new for me. I thought right shift always fills the most significant bits with 0 but I just learned that there is a difference between logical and arithmetic bit shifting.
    The logical bit shifting will fill all the new values with 0. Arithmetic right shifting on the other hand will copy the the MSB for all the new bits to guaranty the result will be half of the original value and therefore performing an arithmetic division by 2.
    Arithmetic shifting seems to be machine specific though. C doesn't guaranty it.

    • @KazeN64
      @KazeN64  Před 5 dny

      C does arithmetic for signed values and logical for unsigned values. MIPS has instructions to do either in 1 cycle.

  • @MoldyMcdonut
    @MoldyMcdonut Před 5 měsíci

    now i need to see preformance with all of this.

  • @pineapplepie4929
    @pineapplepie4929 Před 5 měsíci +5

    thank you kaze for ruining coding for someone somewhere at some point

  • @JPNEETozaki
    @JPNEETozaki Před 5 měsíci +5

    8:30
    I would if I could, I would if i could...

  • @proxy1035
    @proxy1035 Před 5 měsíci

    man i could watch literal hours of these videos

  • @jamesclark2663
    @jamesclark2663 Před 5 měsíci +2

    Ngl, I actually miss being able to use some tricks like this to make noticeable improvements for tight inner loops of some of my old dos projects. On modern pcs a lot of this stuff would either be operationally insignificant (especially in view of much bigger gains that can be had for doing more common-sense stuff) or even detrimental. But I would be lying if I don't occasionally have things like code-locality cross my mind when writing even the most mundane of functions sometimes. I totally get the whole 'Now my day is ruined' comment about inverting logic lol

  • @__8120
    @__8120 Před 5 měsíci +3

    "We can edit the data that is supposed to be const" I think I just threw up a little